Merge pull request #1626 from qidonna/swg

Add setOnLoginRequest to BasicRuntime init()
subscriptions-project · Apr 26, 2021 · 70fa7ca · 70fa7ca
2 parents dfebf79 + 4aac30c
commit 70fa7ca
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 12 deletions.
diff --git a/src/api/basic-subscriptions.js b/src/api/basic-subscriptions.js
@@ -56,10 +56,9 @@ export class BasicSubscriptions {
 
   /**
    * Open CheckEntitlementsView to let users log in Google and check their entitlements.
-   * @param {function(!LoginRequest)} callback
    * @return {?}
    */
-  setOnLoginRequest(callback) {}
+  setOnLoginRequest() {}
 
   /**
    * Creates and displays a SwG subscription or contribution prompt, where the
@@ -106,13 +105,6 @@ export const AutoPromptType = {
  */
 export let ClientOptions;
 
-/**
- * @typedef {{
- *   linkRequested: boolean,
- * }}
- */
-export let LoginRequest;
-
 /** @enum {string} */
 export const ClientTheme = {
   LIGHT: 'light',

diff --git a/src/runtime/basic-runtime.js b/src/runtime/basic-runtime.js
@@ -198,6 +198,7 @@ export class BasicRuntime {
       autoPromptType: params.autoPromptType,
       alwaysShow: false,
     });
+    this.setOnLoginRequest();
   }
   /* eslint-enable no-unused-vars */
 
@@ -216,9 +217,9 @@ export class BasicRuntime {
   }
 
   /** @override */
-  setOnLoginRequest(callback) {
+  setOnLoginRequest() {
     return this.configured_(false).then((runtime) =>
-      runtime.setOnLoginRequest(callback)
+      runtime.setOnLoginRequest()
     );
   }
 
@@ -394,7 +395,7 @@ export class ConfiguredBasicRuntime {
   }
 
   /** @override */
-  setOnLoginRequest(unusedCallback) {
+  setOnLoginRequest() {
     const runtime = this.configuredClassicRuntime_;
     const args = feArgs({
       'publicationId': runtime.pageConfig().getPublicationId(),