This repository has been archived by the owner on Jun 23, 2023. It is now read-only.
Handle rate limit #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stwiname
reviewed
Nov 7, 2022
| return this.callMethod(method, params, retries); | ||
| } else { | ||
| const error = new Error(e.message); | ||
| logger.error(error, `Retry: ${retries} failed`); |
There was a problem hiding this comment.
Suggested change
| logger.error(error, `Retry: ${retries} failed`); | |
| logger.error(error, `Rate limit retries failed after ${RETRY_COUNT}`); |
| async callMethod( | ||
| method: string, | ||
| params: object[] | object, | ||
| retries: number, |
There was a problem hiding this comment.
Lets provide a default then we don't need as many args elsewhere
Suggested change
| retries: number, | |
| retries = RETRY_COUNT, |
| @@ -170,35 +175,89 @@ export class AvalancheApi implements ApiWrapper<AvalancheBlockWrapper> { | |||
| return BigNumber.from(res.data.result).toNumber(); | |||
| } | |||
|
|
|||
| async callMethod( | |||
| method: string, | |||
| params: object[] | object, | |||
There was a problem hiding this comment.
Suggested change
| params: object[] | object, | |
| params: any[], |
5 tasks
jiqiang90
approved these changes
Nov 10, 2022
| }), | ||
| ); | ||
| return new AvalancheBlockWrapped(block); | ||
| return this.fetchBlock(num); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes subquery/subql#1293
Type of change
Checklist