Featuring Memecoin #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deverka
approved these changes
Jan 5, 2024
jamesbayly
reviewed
Jan 5, 2024
| For this project, you can try to query with the following GraphQL code to get a taste of how it works. | ||
|
|
||
| ```graphql | ||
| { |
There was a problem hiding this comment.
Update this to include an example balances query
jamesbayly
reviewed
Jan 5, 2024
| if (address == undefined) { | ||
| address = Address.create({ | ||
| id: accountAddress, | ||
| balance: (await erc20.balanceOf(accountAddress)).toBigInt(), |
There was a problem hiding this comment.
Should you also update the balance of an address if it's known (e.g. refresh this on each new transaction?)
There was a problem hiding this comment.
Ahh I see you do this below
jamesbayly
reviewed
Jan 5, 2024
| }); | ||
|
|
||
| from.balance = BigInt(from.balance) - value; | ||
| to.balance = BigInt(to.balance) + value; |
There was a problem hiding this comment.
I think it's safer to do a full await erc20.balanceOf(accountAddress) There might be other functions and activities that change this so best to clean reset.
Use Promise.all([..,..] for performance for these two queries
jamesbayly
reviewed
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.