Change the statistics type from float64 to uint64 #955
Conversation
aswinsuryan
requested review from
mangelajo,
Oats87,
skitt and
tpantelis
as code owners
|
🤖 Created branch: z_pr955/aswinsuryan/update-health-check-api |
|
Can you provide more detail? What code generator and how did it fail? |
cd vendor/github.com/submariner-io/submariner && controller-gen "crd:crdVersions=v1,trivialVersions=false" paths="./..." output:crd:artifacts:config=../../../../deploy/submariner/crds This is the error it shows. |
The code generator supports only *float64 and hence updating the api Signed-off-by: Aswin Surayanarayanan <[email protected]>
aswinsuryan
force-pushed
the
update-health-check-api
branch
from
c50e70f to
cc5dfd3
Compare
|
🤖 Updated branch: z_pr955/aswinsuryan/update-health-check-api |
1 similar comment
|
🤖 Updated branch: z_pr955/aswinsuryan/update-health-check-api |
|
Discussed on chat - we should just change them to uint64. |
Signed-off-by: Aswin Surayanarayanan <[email protected]>
aswinsuryan
force-pushed
the
update-health-check-api
branch
from
0ce3a42 to
84508d0
Compare
|
🤖 Updated branch: z_pr955/aswinsuryan/update-health-check-api |
aswinsuryan
changed the title
|
🤖 Updated branch: z_pr955/aswinsuryan/update-health-check-api |
|
pkg/apis/submariner.io/v1/types.go
Outdated
| @@ -86,11 +86,11 @@ type GatewayStatus struct { | |||
| // LatencySpec describes the round trip time information in miliseconds for a packet | |||
There was a problem hiding this comment.
To preserve the granularity, shouldn’t the values use a finer unit, say microseconds or nanoseconds?
There was a problem hiding this comment.
Ok the time period gives it in nano seconds, I will change it to nano seconds.
Signed-off-by: Aswin Surayanarayanan <[email protected]>
aswinsuryan
force-pushed
the
update-health-check-api
branch
from
d1f3b90 to
d022da6
Compare
|
🤖 Updated branch: z_pr955/aswinsuryan/update-health-check-api |
|
🤖 Updated branch: z_pr955/aswinsuryan/update-health-check-api |
|
🤖 Closed branches: [z_pr955/aswinsuryan/update-health-check-api] |
The code generator does not support float64 and hence updating
the API to use uint64
Signed-off-by: Aswin Surayanarayanan [email protected]