Add fields for HealthCheck #902
Conversation
aswinsuryan
requested review from
mangelajo,
Oats87,
skitt and
tpantelis
as code owners
|
🤖 Created branch: z_pr902/aswinsuryan/health-check-api |
|
🤖 Updated branch: z_pr902/aswinsuryan/health-check-api |
aswinsuryan
force-pushed
the
health-check-api
branch
from
19fe2c3 to
7028f0d
Compare
|
🤖 Updated branch: z_pr902/aswinsuryan/health-check-api |
aswinsuryan
force-pushed
the
health-check-api
branch
from
7028f0d to
245ae95
Compare
|
🤖 Updated branch: z_pr902/aswinsuryan/health-check-api |
aswinsuryan
force-pushed
the
health-check-api
branch
from
245ae95 to
76fbe6a
Compare
|
🤖 Updated branch: z_pr902/aswinsuryan/health-check-api |
aswinsuryan
force-pushed
the
health-check-api
branch
from
76fbe6a to
3807b06
Compare
|
🤖 Updated branch: z_pr902/aswinsuryan/health-check-api |
|
🤖 Updated branch: z_pr902/aswinsuryan/health-check-api |
|
🤖 Updated branch: z_pr902/aswinsuryan/health-check-api |
|
🤖 Updated branch: z_pr902/aswinsuryan/health-check-api |
|
🤖 Updated branch: z_pr902/aswinsuryan/health-check-api |
aswinsuryan
force-pushed
the
health-check-api
branch
from
d77ec6b to
63fdbcf
Compare
|
🤖 Updated branch: z_pr902/aswinsuryan/health-check-api |
|
🤖 Updated branch: z_pr902/aswinsuryan/health-check-api |
*HealthCheck Ip is added in EndpointSpec *Latency is added in GatewayStatus Fixes: submariner-io#821 Signed-off-by: Aswin Surayanarayanan <[email protected]>
aswinsuryan
force-pushed
the
health-check-api
branch
from
be99fb7 to
6e612d6
Compare
|
🤖 Updated branch: z_pr902/aswinsuryan/health-check-api |
aswinsuryan
force-pushed
the
health-check-api
branch
from
6e612d6 to
87c72d2
Compare
|
🤖 Updated branch: z_pr902/aswinsuryan/health-check-api |
aswinsuryan
force-pushed
the
health-check-api
branch
from
87c72d2 to
dbf5575
Compare
|
🤖 Updated branch: z_pr902/aswinsuryan/health-check-api |
| AverageRTT time.Duration `json:"averageRTT"` | ||
| MaxRTT time.Duration `json:"maxRTT"` | ||
| StdDevRTT time.Duration `json:"stddevRTT"` | ||
| LastRTT float64 `json:"lastRTT"` |
There was a problem hiding this comment.
What's the reason for changing these to float and ms units?
There was a problem hiding this comment.
The value in nano seconds seems to be not understandable, like
Latency:
Average RTT: 585160
Last RTT: 403876
Max RTT: 839461
Min RTT: 403876
Stddev RTT: 185170
So to make it similar to normal ping response changed it to float and ms unit
Latency:
Average RTT: 0.724
Last RTT: 0.635
Max RTT: 0.857
Min RTT: 0.635
Stddev RTT: 0.095
There was a problem hiding this comment.
OK - but it was already approved in the previous form so now need re-review.
@nyechiel seems reasonable - what do you think?
|
The purpose of this PR is to add fields and it has had several review cycles already. I think the last commit to add implementation n should be in another PR. |
SInce I changed the API , I thought it can go together . I will revert to the original one. |
aswinsuryan
force-pushed
the
health-check-api
branch
from
dbf5575 to
b5234c4
Compare
|
🤖 Updated branch: z_pr902/aswinsuryan/health-check-api |
Signed-off-by: Aswin Surayanarayanan <[email protected]>
aswinsuryan
force-pushed
the
health-check-api
branch
from
b5234c4 to
4628f74
Compare
|
🤖 Updated branch: z_pr902/aswinsuryan/health-check-api |
tpantelis
dismissed stale reviews from sridhargaddam and themself
needs re-review
|
🤖 Updated branch: z_pr902/aswinsuryan/health-check-api |
|
🤖 Closed branches: [z_pr902/aswinsuryan/health-check-api] |
*HealthCheck Ip is added in EndpointSpec
*Latency is added in GatewayStatus
Fixes: #821
Signed-off-by: Aswin Surayanarayanan [email protected]