-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow running just the e2e tests #488
Allow running just the e2e tests #488
Conversation
🤖 Created branch: z_pr488/mangelajo/add-e2e-tests-independent-target |
This is useful when working on the e2e tests, you can deploy once and run e2e-tests many times. ``` make e2e status=keep ... modify your e2e tests here ... make e2e-tests ```
e21f1fe
to
e8315d2
Compare
🤖 Updated branch: z_pr488/mangelajo/add-e2e-tests-independent-target |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No let's not do this please, it's very possible to run just the E2E tests with make.
The command is make e2e -o deploy
I don't think we need an entire target for a feature that's already supported by make, do we?
@mkolesnik I have proposed an extended version of this, because -o deploy doesn't work in my system. Also the new proposal brings new features and it's cleaner. |
🤖 Closed branches: [z_pr488/mangelajo/add-e2e-tests-independent-target] |
This is useful when working on the e2e tests, you can deploy once
and run e2e-tests many times.