Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shipyard framework By instead of ginkgo By #2966

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

tpantelis
Copy link
Contributor

This alows flexibility to format or omit the output.

Related to submariner-io/subctl#131

@tpantelis tpantelis self-assigned this Apr 2, 2024
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr2966/tpantelis/use_framework_by
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@tpantelis tpantelis requested a review from aswinsuryan April 2, 2024 12:11
@tpantelis tpantelis changed the title Use shipyard framework By instaed of ginkgo By Use shipyard framework By instead of ginkgo By Apr 2, 2024
This alows flexibility to format or omit the output.

Related to submariner-io/subctl#131

Signed-off-by: Tom Pantelis <[email protected]>
@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Apr 3, 2024
@skitt skitt merged commit ab04c8b into submariner-io:devel Apr 3, 2024
38 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr2966/tpantelis/use_framework_by]

@tpantelis tpantelis deleted the use_framework_by branch April 9, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-test When a PR is ready for full E2E testing
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants