Automated backport of #2778: Pass ctx to datastoreSyncer Start method #2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and propagate to the Federator methods so the caller can cancel and/or put a deadline on the operations. This also required further propagating the ctx params where appropriate to satisfy the contextcheck linter. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
requested review from
Oats87,
skitt and
sridhargaddam
as code owners
|
🤖 Created branch: z_pr2779/tpantelis/automated-backport-of-#2778-upstream-release-0.16 |
skitt
approved these changes
Oct 31, 2023
sridhargaddam
approved these changes
Oct 31, 2023
|
🤖 Closed branches: [z_pr2779/tpantelis/automated-backport-of-#2778-upstream-release-0.16] |
tpantelis
deleted the
automated-backport-of-#2778-upstream-release-0.16
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2778 on release-0.16.
#2778: Pass ctx to datastoreSyncer Start method
For details on the backport process, see the backport requests page.