Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable OVN IC CI #2650

Closed
wants to merge 2 commits into from
Closed

Enable OVN IC CI #2650

wants to merge 2 commits into from

Conversation

dfarrell07
Copy link
Member

This will be removed once we're ready to default to OVN IC.

Relates-to: submariner-io/enhancements#209

@dfarrell07
Update Shipyard to get OVN IC support
14b6257 
Signed-off-by: Daniel Farrell <[email protected]>
@dfarrell07
Enable OVN IC CI
fee43db 
This will be removed once we're ready to default to OVN IC.

Relates-to: submariner-io/enhancements#209
Signed-off-by: Daniel Farrell <[email protected]>
@dfarrell07 dfarrell07 self-assigned this Aug 16, 2023
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr2650/dfarrell07/ovn_ic_ci_pr
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@dfarrell07 dfarrell07 added the ready-to-test When a PR is ready for full E2E testing label Aug 16, 2023
@dfarrell07
Copy link
Member Author

There seems to be an issue.

OVN IC:

2023-08-16T19:27:14.9265319Z Cluster settings::
2023-08-16T19:27:14.9266127Z   broker - 'cluster1'
2023-08-16T19:27:14.9266611Z   clusters - 'cluster1' 'cluster2'
2023-08-16T19:27:14.9267107Z   cni - ([cluster2]="" [cluster1]="" )

vs OVN:

2023-08-16T19:25:17.8719530Z Cluster settings::
2023-08-16T19:25:17.8720305Z   broker - 'cluster1'
2023-08-16T19:25:17.8720891Z   clusters - 'cluster1' 'cluster2'
2023-08-16T19:25:17.8721338Z   cni - ([cluster2]="ovn" [cluster1]="ovn" )

@dfarrell07 dfarrell07 marked this pull request as draft August 16, 2023 20:51
@aswinsuryan
Copy link
Contributor

@dfarrell07 do we still have this issue? It would be great if we could get this merged as it can avoid any regression in ovn-ic.

@stale
Copy link

stale bot commented Oct 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 15, 2023
@tpantelis
Copy link
Contributor

Is this still relevant?

@stale stale bot removed the wontfix This will not be worked on label Nov 3, 2023
@aswinsuryan
Copy link
Contributor

Is this still relevant?

yes this is important for us, now IC implementation is not getting tested in CI

@tpantelis
Copy link
Contributor

Is this still relevant?

yes this is important for us, now IC implementation is not getting tested in CI

OK then I assume this should be planned for 0.17 so I moved it to the board.

@tpantelis
Copy link
Contributor

Is this still relevant?

yes this is important for us, now IC implementation is not getting tested in CI

OK then I assume this should be planned for 0.17 so I moved it to the board.

Oh I see the enhancement is already on the board.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further
activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 19, 2023
@github-actions github-actions bot closed this Nov 27, 2023
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr2650/dfarrell07/ovn_ic_ci_pr]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkolesnik mkolesnik Awaiting requested review from mkolesnik mkolesnik is a code owner

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@skitt skitt Awaiting requested review from skitt skitt is a code owner

@sridhargaddam sridhargaddam Awaiting requested review from sridhargaddam sridhargaddam is a code owner

@tpantelis tpantelis Awaiting requested review from tpantelis tpantelis is a code owner

@aswinsuryan aswinsuryan Awaiting requested review from aswinsuryan aswinsuryan will be requested when the pull request is marked ready for review aswinsuryan is a code owner

@maayanf24 maayanf24 Awaiting requested review from maayanf24 maayanf24 will be requested when the pull request is marked ready for review maayanf24 is a code owner

@vthapar vthapar Awaiting requested review from vthapar vthapar will be requested when the pull request is marked ready for review vthapar is a code owner

@yboaron yboaron Awaiting requested review from yboaron yboaron will be requested when the pull request is marked ready for review yboaron is a code owner

Assignees

@dfarrell07 dfarrell07

Labels
automation ready-to-test When a PR is ready for full E2E testing stale
Projects
No open projects
Submariner 0.17
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dfarrell07 @submariner-bot @aswinsuryan @tpantelis