Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add handlers to create GatewayRoute and NonGatewayRoute CRs #2569

Merged
merged 7 commits into from
Jul 29, 2023
Merged

Add handlers to create GatewayRoute and NonGatewayRoute CRs #2569

merged 7 commits into from
Jul 29, 2023

Conversation

aswinsuryan
Copy link
Contributor

@aswinsuryan aswinsuryan commented Jun 20, 2023 •
edited
Loading

These handlers will create the GatewayRoute and NonGatewayRoute CRs in response to endpoint create event

It will respond to gateway transition event, by creating the CRs in the new gateway node and deleting them in the old nodes.

Fixes: submariner-io/enhancements#203

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr2569/aswinsuryan/ovn-ic-handler
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@aswinsuryan aswinsuryan force-pushed the ovn-ic-handler branch 3 times, most recently from 8a65882 to 9bdc5ca Compare June 21, 2023 19:42
@aswinsuryan aswinsuryan marked this pull request as ready for review June 21, 2023 19:52
@aswinsuryan aswinsuryan force-pushed the ovn-ic-handler branch 2 times, most recently from 565070c to 984fe4a Compare July 10, 2023 16:31
@dfarrell07
Copy link
Member

@aswinsuryan Needs a manual rebase

@aswinsuryan aswinsuryan force-pushed the ovn-ic-handler branch 5 times, most recently from 5c6ff97 to f293648 Compare July 25, 2023 18:45
@aswinsuryan aswinsuryan force-pushed the ovn-ic-handler branch 5 times, most recently from dedd44f to 9ea4bf3 Compare July 25, 2023 20:59
@aswinsuryan
Change handler names and fix issues
4665abc 
Signed-off-by: Aswin Suryanarayanan <[email protected]>
@aswinsuryan
Changed file names for new handlers
a21da32 
Signed-off-by: Aswin Suryanarayanan <[email protected]>
@tpantelis
Copy link
Contributor

I'll give @sridhargaddam a chance to review.

@tpantelis tpantelis added the ready-to-test When a PR is ready for full E2E testing label Jul 29, 2023
@tpantelis tpantelis merged commit c72b94d into submariner-io:devel Jul 29, 2023
39 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr2569/aswinsuryan/ovn-ic-handler]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yboaron yboaron yboaron approved these changes

@tpantelis tpantelis tpantelis approved these changes

@sridhargaddam sridhargaddam sridhargaddam approved these changes

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@skitt skitt Awaiting requested review from skitt skitt is a code owner

Assignees
No one assigned
Labels
ready-to-test When a PR is ready for full E2E testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add handler to create GatewayRoute and Non GatewayRouteCRs
7 participants
@aswinsuryan @submariner-bot @dfarrell07 @tpantelis @skitt @sridhargaddam @yboaron