Pin Admiral to v0.13.1 #2032
Merged
Pin Admiral to v0.13.1 #2032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
submariner-bot
requested review from
Oats87,
skitt,
sridhargaddam and
tpantelis
as code owners
|
🤖 I see this PR is using the local branch workflow, ignoring it on my side, have fun! |
tpantelis
approved these changes
Sep 21, 2022
skitt
approved these changes
Sep 21, 2022
dfarrell07
added a commit
to dfarrell07/releases
that referenced
this pull request
Sep 21, 2022
After submariner-io#470, the release GitHub Action workflow is failing to add labels to PRs. ``` gh pr edit --add-label e2e-all-k8s \ submariner-io/submariner#2032 GraphQL: Your token has not been granted the required scopes to execute this query. The 'login' field requires one of the following scopes: ['read:org'], but your token has only been granted the: ['admin:repo_hook', 'delete:packages', 'notifications', 'repo', 'workflow', 'write:discussion', 'write:packages'] scopes. Please modify your token's scopes at: https://github.com/settings/tokens. INFO: Didn't label 'e2e-all-k8s', continuing without it. ``` The only explination I can find of that permisson is: > read:org Read org and team membership, read org projects I can also see that permission is a subset of admin:org. It seems to be different than `read:project Read access of projects` somehow. It's not clear which GITHUB_TOKEN permisison we can set relates to those token permissions. docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs It doesn't seem possible set all permissions to read and only some to write, as setting any specific permission overrides read-all. For now, trying the only permission that seems even vaguely related. Signed-off-by: Daniel Farrell <[email protected]>
|
This is failing because Shipyard 0.13.1 runs |
Signed-off-by: Automated Release <[email protected]>
tpantelis
force-pushed
the
pin_admiral
branch
from
2f94f15 to
3bba441
Compare
I fixed it up manually (I hope 😄 ). |
skitt
pushed a commit
to submariner-io/releases
that referenced
this pull request
Sep 21, 2022
After #470, the release GitHub Action workflow is failing to add labels to PRs. ``` gh pr edit --add-label e2e-all-k8s \ submariner-io/submariner#2032 GraphQL: Your token has not been granted the required scopes to execute this query. The 'login' field requires one of the following scopes: ['read:org'], but your token has only been granted the: ['admin:repo_hook', 'delete:packages', 'notifications', 'repo', 'workflow', 'write:discussion', 'write:packages'] scopes. Please modify your token's scopes at: https://github.com/settings/tokens. INFO: Didn't label 'e2e-all-k8s', continuing without it. ``` The only explination I can find of that permisson is: > read:org Read org and team membership, read org projects I can also see that permission is a subset of admin:org. It seems to be different than `read:project Read access of projects` somehow. It's not clear which GITHUB_TOKEN permisison we can set relates to those token permissions. docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs It doesn't seem possible set all permissions to read and only some to write, as setting any specific permission overrides read-all. For now, trying the only permission that seems even vaguely related. Signed-off-by: Daniel Farrell <[email protected]>
dfarrell07
approved these changes
Sep 21, 2022
dfarrell07
requested changes
Sep 21, 2022
|
dfarrell07
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin Admiral to v0.13.1