[E2E] Use weave as default cni for all k8s and kind versions. #123
Conversation
dimaunx
changed the title
| @@ -19,13 +19,14 @@ function kind_clusters() { | |||
| echo Creating cluster${i}, logging to ${logs[$i]}... | |||
| ( | |||
| if [[ -n ${version} ]]; then | |||
| kind create cluster --image=kindest/node:v${version} --name=cluster${i} --wait=5m --config=${PRJ_ROOT}/scripts/kind-e2e/cluster${i}-config.yaml | |||
| kind create cluster --image=kindest/node:v${version} --name=cluster${i} --config=${PRJ_ROOT}/scripts/kind-e2e/cluster${i}-config.yaml | |||
There was a problem hiding this comment.
Why do we remove the wait=5m? :)
There was a problem hiding this comment.
The control plain comes up without cni, --wait waits for control plain to be up and its never up until we apply weave cni.
There was a problem hiding this comment.
ohh, makes sense, thanks :-D
| echo "Weave already deployed cluster${i}." | ||
| else | ||
| echo "Applying weave network in to cluster${i}..." | ||
| kubectl --context=cluster${i} apply -f "https://cloud.weave.works/k8s/net?k8s-version=$(kubectl version | base64 | tr -d '\n')&env.IPALLOC_RANGE=${POD_CIDR[cluster${i}]}" |
There was a problem hiding this comment.
oh wow! :D that's neat of them!
|
@sridhargaddam will love this ;) |
Yes :) |
Yes that's nice idea. I have also tested calico, but had some issues related to kernel modules. Seems to be fixable. Didn't want to waste too much time and used weave instead. Seems as long as cni supports podCidr customization we can utilize most of them. |
There was a problem hiding this comment.
Looks good. Verified the patch and it works fine :)
Great fix @dimaunx
This PR uses Cluster.networking.disableDefaultCNI option for clusters 2 and 3. After the container nodes are up we are installing weave manually. In previous setup with k8s version 1.14.1, weave was ignoring podCidr provided in kind config file and used its default 10.32.0.0/12 cidr as podCidr. This PR fixes this issue.The result is a cluster with weave and podCidr that is taken from kind config file. This removes the need to be constrained to specific k8s version or kind version. After this is merged kind can be safely upgraded. Other types of cni plugins can be tested more easily.