Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate exporting Submariner metrics without needing to open ports #1944

Closed
5 tasks done
skitt opened this issue Aug 1, 2022 · 3 comments
Closed
5 tasks done

Investigate exporting Submariner metrics without needing to open ports #1944

skitt opened this issue Aug 1, 2022 · 3 comments
Assignees
@vthapar
Labels
enhancement New feature or request size:small This can be implemented in less than half a sprint

Comments

@skitt
Copy link
Member

skitt commented Aug 1, 2022 •
edited by vthapar
Loading

Currently we need to open ports to access some Submariner metrics (at least those exported on a port on the host network).

We should look into some other way of exporting the metrics which doesn’t require this. One possible idea is to use NodePort.

Work Items
@skitt skitt added the enhancement New feature or request label Aug 1, 2022
@sridhargaddam
Copy link
Member

Note: Currently we open the Metrics port (TCP/8080 and TCP/8081) only within the local cluster and not to the outside world. Using NodePort might solve the issue, but it can open the corresponding port globally which may not be what we want.

vthapar added a commit to vthapar/enhancements that referenced this issue Aug 11, 2022
@vthapar
Submariner metrics redesign
66cdc48 
Submariner Gateway and Globalnet metrics require port to be opened
on host for them to be accessible. This EP proposes a redesign
which allows metrics to be accessible without requiring to open
any ports in infra.

Fixes github.com/submariner-io/submariner/issues/1944

Signed-off-by: Vishal Thapar <[email protected]>
@vthapar vthapar mentioned this issue Aug 11, 2022
Merged
vthapar added a commit to vthapar/enhancements that referenced this issue Aug 11, 2022
@vthapar
Submariner metrics redesign
43c7edd 
Submariner Gateway and Globalnet metrics require port to be opened
on host for them to be accessible. This EP proposes a redesign
which allows metrics to be accessible without requiring to open
any ports in infra.

Fixes github.com/submariner-io/submariner/issues/1944

Signed-off-by: Vishal Thapar <[email protected]>
vthapar added a commit to vthapar/enhancements that referenced this issue Aug 11, 2022
@vthapar
Submariner metrics redesign
6acb316 
Submariner Gateway and Globalnet metrics require port to be opened
on host for them to be accessible. This EP proposes a redesign
which allows metrics to be accessible without requiring to open
any ports in infra.

Fixes github.com/submariner-io/submariner/issues/1944

Signed-off-by: Vishal Thapar <[email protected]>
@vthapar vthapar added the size:small This can be implemented in less than half a sprint label Aug 11, 2022
vthapar added a commit to vthapar/enhancements that referenced this issue Aug 11, 2022
@vthapar
Submariner metrics redesign
a11a949 
Submariner Gateway and Globalnet metrics require port to be opened
on host for them to be accessible. This EP proposes a redesign
which allows metrics to be accessible without requiring to open
any ports in infra.

Fixes github.com/submariner-io/submariner/issues/1944

Signed-off-by: Vishal Thapar <[email protected]>
vthapar added a commit to vthapar/enhancements that referenced this issue Aug 18, 2022
@vthapar
Submariner metrics redesign
d61757e 
Submariner Gateway and Globalnet metrics require port to be opened
on host for them to be accessible. This EP proposes a redesign
which allows metrics to be accessible without requiring to open
any ports in infra.

Refer github.com/submariner-io/submariner/issues/1944

Signed-off-by: Vishal Thapar <[email protected]>
vthapar added a commit to submariner-io/enhancements that referenced this issue Aug 18, 2022
@vthapar
Submariner metrics redesign (#128)
0354c33 
Submariner Gateway and Globalnet metrics require port to be opened
on host for them to be accessible. This EP proposes a redesign
which allows metrics to be accessible without requiring to open
any ports in infra.

Refer github.com/submariner-io/submariner/issues/1944

Signed-off-by: Vishal Thapar <[email protected]>
@vthapar
Copy link
Contributor

vthapar commented Sep 8, 2022

@skitt @nyechiel Can we close this now, or when it becomes part of next milestone release?

@nyechiel
Copy link
Member

nyechiel commented Sep 8, 2022

@skitt @nyechiel Can we close this now, or when it becomes part of next milestone release?

I think we can close it. This is fixed by: submariner-io/submariner-operator#2182

@vthapar can you please make sure we track any docs changes (actual docs and release notes) separately?

@nyechiel nyechiel closed this as completed Sep 8, 2022
This was referenced Sep 13, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vthapar vthapar

Labels
enhancement New feature or request size:small This can be implemented in less than half a sprint
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@skitt @vthapar @sridhargaddam @nyechiel