Cloud prepare doesn't open metrics ports #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of metrics proxy redesign, we no longer need to open ports 8080 and 8081 in the firewall as part of cloud prepare. Refer submariner-io/enhancements#128 Signed-off-by: Vishal Thapar <[email protected]>
vthapar
requested review from
dfarrell07,
Oats87,
skitt,
sridhargaddam and
tpantelis
as code owners
|
🤖 Created branch: z_pr844/vthapar/metrics-ports |
✅ Deploy Preview for elated-bell-2913d9 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
3 tasks
skitt
approved these changes
Oct 27, 2022
nyechiel
approved these changes
Oct 27, 2022
|
🤖 Closed branches: [z_pr844/vthapar/metrics-ports] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of metrics proxy redesign, we no longer need to open ports 8080 and 8081 in the firewall as part of cloud prepare.
Refer submariner-io/enhancements#128
Signed-off-by: Vishal Thapar [email protected]