-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TCP port to Lighthouse CoreDNS ClusterIP service #3220
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Created branch: z_pr3220/t0lya/add-tcp-lighthouse-dns |
t0lya
force-pushed
the
add-tcp-lighthouse-dns
branch
from
September 11, 2024 18:26
9a4f3e5
to
5e07b68
Compare
t0lya
requested review from
Oats87,
skitt,
sridhargaddam,
tpantelis and
vthapar
as code owners
September 11, 2024 20:29
tpantelis
approved these changes
Sep 11, 2024
t0lya
force-pushed
the
add-tcp-lighthouse-dns
branch
from
September 11, 2024 22:22
5e07b68
to
9a37cd1
Compare
Define TCP port in ClusterIP service to allow k8s DNS server to forward TCP connection requests. Lighthouse CoreDNS pods already support TCP on port 53. This is needed to support TCP retries after truncation per RFC1035 and RFC2181. Signed-off-by: Tony Le <[email protected]>
t0lya
force-pushed
the
add-tcp-lighthouse-dns
branch
from
September 11, 2024 22:33
9a37cd1
to
f90c97d
Compare
aswinsuryan
approved these changes
Sep 13, 2024
🤖 Closed branches: [z_pr3220/t0lya/add-tcp-lighthouse-dns] |
vthapar
added
backport
This change requires a backport to eligible release branches
release-note-needed
Should be mentioned in the release notes
labels
Sep 17, 2024
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Sep 23, 2024
Release notes for submariner-io/submariner-operator#3220 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Sep 23, 2024
Release notes for submariner-io/submariner-operator#3220 Signed-off-by: Tom Pantelis <[email protected]>
yboaron
pushed a commit
to yboaron/submariner-website
that referenced
this pull request
Sep 24, 2024
Release notes for submariner-io/submariner-operator#3220 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to submariner-io/submariner-website
that referenced
this pull request
Sep 24, 2024
Release notes for submariner-io/submariner-operator#3220 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Sep 24, 2024
Release notes for submariner-io/submariner-operator#3220 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Sep 24, 2024
Release notes for submariner-io/submariner-operator#3220 Signed-off-by: Tom Pantelis <[email protected]>
This was referenced Sep 24, 2024
Merged
yboaron
added a commit
to submariner-io/submariner-website
that referenced
this pull request
Sep 30, 2024
* Add 0.19 release notes for submariner-operator PR #3220 Release notes for submariner-io/submariner-operator#3220 Signed-off-by: Tom Pantelis <[email protected]> * Release notes for submariner-io/submariner/pull/3156 submariner-io/submariner/pull/3121 Signed-off-by: Yossi Boaron <[email protected]> --------- Signed-off-by: Tom Pantelis <[email protected]> Signed-off-by: Yossi Boaron <[email protected]> Co-authored-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to submariner-io/submariner-website
that referenced
this pull request
Oct 1, 2024
Release notes for submariner-io/submariner-operator#3220 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to submariner-io/submariner-website
that referenced
this pull request
Oct 1, 2024
Release notes for submariner-io/submariner-operator#3220 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Oct 7, 2024
Release notes for submariner-io/submariner-operator#3220 Signed-off-by: Tom Pantelis <[email protected]>
skitt
pushed a commit
to submariner-io/submariner-website
that referenced
this pull request
Oct 7, 2024
Release notes for submariner-io/submariner-operator#3220 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Oct 9, 2024
Release notes for submariner-io/submariner-operator#3220 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to submariner-io/submariner-website
that referenced
this pull request
Oct 9, 2024
Release notes for submariner-io/submariner-operator#3220 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Oct 25, 2024
Release notes for submariner-io/submariner-operator#3220 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Oct 25, 2024
…o#1177) * Add 0.19 release notes for submariner-operator PR #3220 Release notes for submariner-io/submariner-operator#3220 Signed-off-by: Tom Pantelis <[email protected]> * Release notes for submariner-io/submariner/pull/3156 submariner-io/submariner/pull/3121 Signed-off-by: Yossi Boaron <[email protected]> --------- Signed-off-by: Tom Pantelis <[email protected]> Signed-off-by: Yossi Boaron <[email protected]> Co-authored-by: Tom Pantelis <[email protected]>
dfarrell07
pushed a commit
to submariner-io/submariner-website
that referenced
this pull request
Oct 25, 2024
Release notes for submariner-io/submariner-operator#3220 Signed-off-by: Tom Pantelis <[email protected]>
dfarrell07
pushed a commit
to submariner-io/submariner-website
that referenced
this pull request
Oct 25, 2024
* Add 0.19 release notes for submariner-operator PR #3220 Release notes for submariner-io/submariner-operator#3220 Signed-off-by: Tom Pantelis <[email protected]> * Release notes for submariner-io/submariner/pull/3156 submariner-io/submariner/pull/3121 Signed-off-by: Yossi Boaron <[email protected]> --------- Signed-off-by: Tom Pantelis <[email protected]> Signed-off-by: Yossi Boaron <[email protected]> Co-authored-by: Tom Pantelis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
This change requires a backport to eligible release branches
backport-handled
ready-to-test
When a PR is ready for full E2E testing
release-note-handled
release-note-needed
Should be mentioned in the release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define TCP port in ClusterIP service to allow k8s DNS server to forward TCP connection requests. Lighthouse CoreDNS pods already support TCP on port 53.
This is needed to support TCP retries after truncation per RFC1035 and RFC2181.
Fixes #3218