Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TCP port to Lighthouse CoreDNS ClusterIP service #3220

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

t0lya
Copy link
Contributor

@t0lya t0lya commented Sep 11, 2024

Define TCP port in ClusterIP service to allow k8s DNS server to forward TCP connection requests. Lighthouse CoreDNS pods already support TCP on port 53.

This is needed to support TCP retries after truncation per RFC1035 and RFC2181.

Fixes #3218

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr3220/t0lya/add-tcp-lighthouse-dns
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@t0lya t0lya marked this pull request as ready for review September 11, 2024 20:29
Define TCP port in ClusterIP service to allow k8s DNS
server to forward TCP connection requests.
Lighthouse CoreDNS pods already support TCP on port 53.
This is needed to support TCP retries after truncation
per RFC1035 and RFC2181.
Signed-off-by: Tony Le <[email protected]>
@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Sep 13, 2024
@tpantelis tpantelis enabled auto-merge (rebase) September 16, 2024 16:05
@tpantelis tpantelis merged commit ac8ad84 into submariner-io:devel Sep 16, 2024
35 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr3220/t0lya/add-tcp-lighthouse-dns]

@vthapar vthapar added backport This change requires a backport to eligible release branches release-note-needed Should be mentioned in the release notes labels Sep 17, 2024
tpantelis added a commit to tpantelis/submariner-website that referenced this pull request Sep 23, 2024
tpantelis added a commit to tpantelis/submariner-website that referenced this pull request Sep 23, 2024
yboaron pushed a commit to yboaron/submariner-website that referenced this pull request Sep 24, 2024
tpantelis added a commit to submariner-io/submariner-website that referenced this pull request Sep 24, 2024
tpantelis added a commit to tpantelis/submariner-website that referenced this pull request Sep 24, 2024
tpantelis added a commit to tpantelis/submariner-website that referenced this pull request Sep 24, 2024
yboaron added a commit to submariner-io/submariner-website that referenced this pull request Sep 30, 2024
* Add 0.19 release notes for submariner-operator PR #3220

Release notes for submariner-io/submariner-operator#3220

Signed-off-by: Tom Pantelis <[email protected]>

* Release notes for

submariner-io/submariner/pull/3156
submariner-io/submariner/pull/3121

Signed-off-by: Yossi Boaron <[email protected]>

---------

Signed-off-by: Tom Pantelis <[email protected]>
Signed-off-by: Yossi Boaron <[email protected]>
Co-authored-by: Tom Pantelis <[email protected]>
tpantelis added a commit to submariner-io/submariner-website that referenced this pull request Oct 1, 2024
tpantelis added a commit to submariner-io/submariner-website that referenced this pull request Oct 1, 2024
tpantelis added a commit to tpantelis/submariner-website that referenced this pull request Oct 7, 2024
skitt pushed a commit to submariner-io/submariner-website that referenced this pull request Oct 7, 2024
tpantelis added a commit to tpantelis/submariner-website that referenced this pull request Oct 9, 2024
tpantelis added a commit to submariner-io/submariner-website that referenced this pull request Oct 9, 2024
tpantelis added a commit to tpantelis/submariner-website that referenced this pull request Oct 25, 2024
tpantelis added a commit to tpantelis/submariner-website that referenced this pull request Oct 25, 2024
…o#1177)

* Add 0.19 release notes for submariner-operator PR #3220

Release notes for submariner-io/submariner-operator#3220

Signed-off-by: Tom Pantelis <[email protected]>

* Release notes for

submariner-io/submariner/pull/3156
submariner-io/submariner/pull/3121

Signed-off-by: Yossi Boaron <[email protected]>

---------

Signed-off-by: Tom Pantelis <[email protected]>
Signed-off-by: Yossi Boaron <[email protected]>
Co-authored-by: Tom Pantelis <[email protected]>
dfarrell07 pushed a commit to submariner-io/submariner-website that referenced this pull request Oct 25, 2024
dfarrell07 pushed a commit to submariner-io/submariner-website that referenced this pull request Oct 25, 2024
* Add 0.19 release notes for submariner-operator PR #3220

Release notes for submariner-io/submariner-operator#3220

Signed-off-by: Tom Pantelis <[email protected]>

* Release notes for

submariner-io/submariner/pull/3156
submariner-io/submariner/pull/3121

Signed-off-by: Yossi Boaron <[email protected]>

---------

Signed-off-by: Tom Pantelis <[email protected]>
Signed-off-by: Yossi Boaron <[email protected]>
Co-authored-by: Tom Pantelis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport This change requires a backport to eligible release branches backport-handled ready-to-test When a PR is ready for full E2E testing release-note-handled release-note-needed Should be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lighthouse DNS unable to handle TCP retries after truncation
5 participants