Automated backport of #2324: Use golangci-lint for header checks #2353: Remove space between // and nolint #2943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goheader's whitespace handling seems to be less fragile than license_checker's. This also means one less job in CI. Signed-off-by: Stephen Kitt <[email protected]>
This is enforced by newer releases of golangci-lint. Signed-off-by: Stephen Kitt <[email protected]>
varcheck, deadcode, and structcheck are deprecated since 1.49.0. Signed-off-by: Stephen Kitt <[email protected]>
This causes conflicts with gci in some cases. Signed-off-by: Stephen Kitt <[email protected]>
Instead of relying on context.TODO(), function using a context should consume one given as a parameter; this allows the reconciliation context to be used consistently. Signed-off-by: Stephen Kitt <[email protected]>
Signed-off-by: Stephen Kitt <[email protected]>
skitt
requested review from
Oats87,
sridhargaddam and
tpantelis
as code owners
|
🤖 Created branch: z_pr2943/skitt/automated-backport-of-#2324-#2353-origin-release-0.14 |
This was referenced Jan 24, 2024
Closed
tpantelis
approved these changes
Jan 24, 2024
vthapar
approved these changes
Jan 24, 2024
|
🤖 Closed branches: [z_pr2943/skitt/automated-backport-of-#2324-#2353-origin-release-0.14] |
skitt
deleted the
automated-backport-of-#2324-#2353-origin-release-0.14
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2324 #2353 on release-0.14.
#2324: Use golangci-lint for header checks
#2353: Remove space between // and nolint
For details on the backport process, see the backport requests page.