Remove networkplugin syncer deployment

[tpantelis]

The controller now deletes the Deployment and associated RBAC resources.

Fixes submariner-io/enhancements#191
Depends on: submariner-io/submariner#2621

[submariner-bot]

🤖 Created branch: z_pr2759/tpantelis/rem_np_syncer
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

[aswinsuryan]

LGTM , @vthapar I think this does some part of submariner-io/enhancements#193

[aswinsuryan]

The OVN test should pass once this is merged submariner-io/submariner#2621

[sridhargaddam]

The OVN test should pass once this is merged submariner-io/submariner#2621

Added a Depends on in the commit message.

[aswinsuryan]

@tpantelis the ovn failure now seems to be related to uninstall.

[tpantelis]

@tpantelis the ovn failure now seems to be related to uninstall.

Looks an issue with the route agent uninstall on the submariner side. Maybe it’s crashing.

[tpantelis]

Looks an issue with the route agent uninstall on the submariner side. Maybe it’s crashing.

panic: close of nil channel

  goroutine 1 [running]:
  github.com/submariner-io/submariner/pkg/routeagent_driver/handlers/ovn.(*GatewayRouteController).stop(...)
  	github.com/submariner-io/submariner/pkg/routeagent_driver/handlers/ovn/gateway_route_controller.go:138
  github.com/submariner-io/submariner/pkg/routeagent_driver/handlers/ovn.(*Handler).Stop(0xc000131ef0, 0x1)
  	github.com/submariner-io/submariner/pkg/routeagent_driver/handlers/ovn/uninstall.go:29 +0x31
https://github.com/submariner-io/submariner/pull/2652

submariner-io/submariner#2652

[submariner-bot]

🤖 Closed branches: [z_pr2759/tpantelis/rem_np_syncer]