Create secrets for serviceaccounts #2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K8s 1.24+ doesn't autocreate secret for serviceaccount. This breaks submariner deployments which expects secret to be created and associated to the corresponding serviceaccount. The fix ensures the Secret of type service-account-token exists, is annotated with ServiceAccount.Name, and is added to Secrets list in the ServiceAccount. Fixes #102 Signed-off-by: Vishal Thapar <[email protected]>
|
🤖 Created branch: z_pr2121/skitt/backport-subctl-125 |
dfarrell07
approved these changes
Jun 30, 2022
nyechiel
approved these changes
Jun 30, 2022
|
@tpantelis ^^ |
tpantelis
approved these changes
Jun 30, 2022
|
🤖 Closed branches: [z_pr2121/skitt/backport-subctl-125] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
K8s 1.24+ doesn't autocreate secret for serviceaccount. This
breaks submariner deployments which expects secret to be created
and associated to the corresponding serviceaccount.
The fix ensures the Secret of type service-account-token exists,
is annotated with ServiceAccount.Name, and is added to Secrets list in
the ServiceAccount.
Signed-off-by: Vishal Thapar [email protected]