Alert for blocked ESP protocol as part of diagnose #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sridhargaddam
requested review from
Jaanki,
Oats87,
skitt and
tpantelis
as code owners
|
🤖 Created branch: z_pr886/sridhargaddam/issue-2658 |
sridhargaddam
force-pushed
the
issue-2658
branch
from
79aa9e4
to
c5051e3
Compare
skitt
requested changes
Aug 28, 2023
sridhargaddam
force-pushed
the
issue-2658
branch
from
c5051e3
to
10f1ba2
Compare
tpantelis
requested changes
Aug 28, 2023
sridhargaddam
force-pushed
the
issue-2658
branch
from
10f1ba2
to
36b3f39
Compare
skitt
requested changes
Aug 28, 2023
tpantelis
approved these changes
Aug 28, 2023
When there is no NAT between the Gateway nodes and Libreswan cable-driver is used, IPsec protocol uses UDP/4500 port for exchanging the keys and ESP for data transfer. As part of subctl diagnose command, this PR now validates if there is a potential issue with ESP and returns appropriate error message. Related to: submariner-io/submariner#2658 Signed-off-by: Sridhar Gaddam <[email protected]>
sridhargaddam
force-pushed
the
issue-2658
branch
from
36b3f39
to
e745bc9
Compare
skitt
approved these changes
Aug 28, 2023
|
🤖 Closed branches: [z_pr886/sridhargaddam/issue-2658] |
dfarrell07
added
the
backport
dfarrell07
added
the
release-note-needed
sridhargaddam
added a commit
to sridhargaddam/submariner-website
that referenced
this pull request
Sep 11, 2023
Release notes for the following PR. submariner-io/subctl#886 Signed-off-by: Sridhar Gaddam <[email protected]>
|
Release note PR: submariner-io/submariner-website#1010 |
skitt
pushed a commit
to submariner-io/submariner-website
that referenced
this pull request
Sep 12, 2023
Release notes for the following PR. submariner-io/subctl#886 Signed-off-by: Sridhar Gaddam <[email protected]>
dfarrell07
pushed a commit
to dfarrell07/submariner-website
that referenced
this pull request
Oct 18, 2023
Release notes for the following PR. submariner-io/subctl#886 Signed-off-by: Sridhar Gaddam <[email protected]>
dfarrell07
pushed a commit
to dfarrell07/submariner-website
that referenced
this pull request
Oct 18, 2023
Release notes for the following PR. submariner-io/subctl#886 Signed-off-by: Sridhar Gaddam <[email protected]>
dfarrell07
pushed a commit
to dfarrell07/submariner-website
that referenced
this pull request
Oct 19, 2023
Release notes for the following PR. submariner-io/subctl#886 Signed-off-by: Sridhar Gaddam <[email protected]>
tpantelis
pushed a commit
to submariner-io/submariner-website
that referenced
this pull request
Oct 22, 2023
Release notes for the following PR. submariner-io/subctl#886 Signed-off-by: Sridhar Gaddam <[email protected]>
tpantelis
pushed a commit
to tpantelis/submariner-website
that referenced
this pull request
Nov 7, 2023
Release notes for the following PR. submariner-io/subctl#886 Signed-off-by: Sridhar Gaddam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is no NAT between the Gateway nodes and Libreswan cable-driver is used, IPsec protocol uses UDP/4500 port for exchanging the keys and ESP for data transfer. As part of subctl diagnose command, this PR now validates if there is a potential issue with ESP and returns appropriate error message.