New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The No "Apply suggestions from code review" Commits GHA needs to be updated #537

Closed

skitt opened this issue Jan 31, 2023 · 8 comments

Assignees

Labels

dependent maintenance priority:high

Member

skitt commented Jan 31, 2023 •

edited

Loading

This GHA will soon run into problems because of GHA feature removals:

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: tim-actions/get-pr-commits@c64db31, tim-actions/commit-message-checker-with-regex@d6d9770. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Depends on tim-actions/get-pr-commits#8
Depends on tim-actions/commit-message-checker-with-regex#8

The text was updated successfully, but these errors were encountered:

skitt added priority:high maintenance labels

github-actions bot added the dependent label

github-actions bot commented Jan 31, 2023

This PR/issue depends on:

Node 12 Actions are deprecated tim-actions/get-pr-commits#8
Node 12 Actions are deprecated tim-actions/commit-message-checker-with-regex#8
By Dependent Issues (🤖). Happy coding!

dfarrell07 self-assigned this

Member

dfarrell07 commented Jan 31, 2023

I was thinking about sending an update, but there are already PRs proposed but not merged.

Depends on tim-actions/get-pr-commits#11
Depends on tim-actions/commit-message-checker-with-regex#12

Member

dfarrell07 commented Feb 1, 2023

One of two merged. 🤞

Member

dfarrell07 commented Mar 8, 2023

Both are merged ✔️

Member

dfarrell07 commented Mar 13, 2023

Not sure if we should wait on releases (might not happen, or at least be slow) or bump manually.

Member Author

skitt commented Mar 13, 2023

Not sure if we should wait on releases (might not happen, or at least be slow) or bump manually.

Let’s bump manually.

dfarrell07 added a commit to dfarrell07/submariner that referenced this issue


          Bump tim-actions/get-pr-commits for Node.js update

ad5079c

Bump to the latest commit, which updates node from 12 to 16 in addition
to an actions/core update.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

dfarrell07 added a commit to dfarrell07/submariner that referenced this issue


          Bump tim-actions/commit-message for Node.js update

e56c041

Bump to the latest commit, which updates node from 12 to 16.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

dfarrell07 added a commit to dfarrell07/submariner-operator that referenced this issue


          Bump tim-actions/get-pr-commits for Node.js update

5f40b21

Bump to the latest commit, which updates node from 12 to 16 in addition
to an actions/core update.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

dfarrell07 added a commit to dfarrell07/submariner-operator that referenced this issue


          Bump tim-actions/commit-message for Node.js update

71ba62b

Bump to the latest commit, which updates node from 12 to 16.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

dfarrell07 added a commit to dfarrell07/admiral that referenced this issue


          Bump tim-actions/commit-message for Node.js update

f1fec38

Bump to the latest commit, which updates node from 12 to 16.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

dfarrell07 added a commit to dfarrell07/admiral that referenced this issue


          Bump tim-actions/get-pr-commits for Node.js update

4a9cb0d

Bump to the latest commit, which updates node from 12 to 16 in addition
to an actions/core update.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

dfarrell07 added a commit to dfarrell07/cloud-prepare that referenced this issue


          Bump tim-actions/get-pr-commits for Node.js update

dc8d23f

Bump to the latest commit, which updates node from 12 to 16 in addition
to an actions/core update.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

dfarrell07 added a commit to dfarrell07/cloud-prepare that referenced this issue


          Bump tim-actions/commit-message for Node.js update

58677b2

Bump to the latest commit, which updates node from 12 to 16.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

tpantelis pushed a commit to submariner-io/cloud-prepare that referenced this issue


          Bump tim-actions/get-pr-commits for Node.js update

65e6c93

Bump to the latest commit, which updates node from 12 to 16 in addition
to an actions/core update.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

tpantelis pushed a commit to submariner-io/cloud-prepare that referenced this issue


          Bump tim-actions/commit-message for Node.js update

38254b6

Bump to the latest commit, which updates node from 12 to 16.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

tpantelis pushed a commit to submariner-io/admiral that referenced this issue


          Bump tim-actions/commit-message for Node.js update

2bf3d1d

Bump to the latest commit, which updates node from 12 to 16.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

tpantelis pushed a commit to submariner-io/admiral that referenced this issue


          Bump tim-actions/get-pr-commits for Node.js update

f75326d

Bump to the latest commit, which updates node from 12 to 16 in addition
to an actions/core update.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

tpantelis pushed a commit to submariner-io/submariner-operator that referenced this issue


          Bump tim-actions/get-pr-commits for Node.js update

f55184b

Bump to the latest commit, which updates node from 12 to 16 in addition
to an actions/core update.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

tpantelis pushed a commit to submariner-io/submariner-operator that referenced this issue


          Bump tim-actions/commit-message for Node.js update

0a28864

Bump to the latest commit, which updates node from 12 to 16.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

skitt pushed a commit to submariner-io/submariner that referenced this issue


          Bump tim-actions/get-pr-commits for Node.js update

2b8fb39

Bump to the latest commit, which updates node from 12 to 16 in addition
to an actions/core update.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

skitt pushed a commit to submariner-io/submariner that referenced this issue


          Bump tim-actions/commit-message for Node.js update

8ce32cb

Bump to the latest commit, which updates node from 12 to 16.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

dfarrell07 added a commit to dfarrell07/shipyard that referenced this issue


          Bump tim-actions/commit-message for Node.js update

84ef96d

Bump to the latest commit, which updates node from 12 to 16.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

dfarrell07 added a commit to dfarrell07/shipyard that referenced this issue


          Bump tim-actions/get-pr-commits for Node.js update

e1543e3

Bump to the latest commit, which updates node from 12 to 16 in addition
to an actions/core update.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

dfarrell07 added a commit to dfarrell07/lighthouse that referenced this issue


          Bump tim-actions/commit-message for Node.js update

d9dcd05

Bump to the latest commit, which updates node from 12 to 16.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

tpantelis pushed a commit to submariner-io/cloud-prepare that referenced this issue


          Bump tim-actions/commit-message for Node.js update

87e3214

Bump to the latest commit, which updates node from 12 to 16.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

tpantelis pushed a commit to submariner-io/cloud-prepare that referenced this issue


          Bump tim-actions/commit-message for Node.js update

0db5c37

Bump to the latest commit, which updates node from 12 to 16.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

tpantelis pushed a commit to submariner-io/cloud-prepare that referenced this issue


          Bump tim-actions/get-pr-commits for Node.js update

7e59850

Bump to the latest commit, which updates node from 12 to 16 in addition
to an actions/core update.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

tpantelis pushed a commit to submariner-io/releases that referenced this issue


          Bump tim-actions/commit-message for Node.js update

6b6c464

Bump to the latest commit, which updates node from 12 to 16.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

tpantelis pushed a commit to submariner-io/releases that referenced this issue


          Bump tim-actions/get-pr-commits for Node.js update

668cca1

Bump to the latest commit, which updates node from 12 to 16 in addition
to an actions/core update.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

tpantelis pushed a commit to submariner-io/admiral that referenced this issue


          Bump tim-actions/commit-message for Node.js update

b5139ae

Bump to the latest commit, which updates node from 12 to 16.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

tpantelis pushed a commit to submariner-io/admiral that referenced this issue


          Bump tim-actions/get-pr-commits for Node.js update

2e3fcb2

Bump to the latest commit, which updates node from 12 to 16 in addition
to an actions/core update.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

tpantelis pushed a commit to submariner-io/releases that referenced this issue


          Bump tim-actions/commit-message for Node.js update

2d009a9

Bump to the latest commit, which updates node from 12 to 16.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

tpantelis pushed a commit to submariner-io/releases that referenced this issue


          Bump tim-actions/get-pr-commits for Node.js update

f48e2a3

Bump to the latest commit, which updates node from 12 to 16 in addition
to an actions/core update.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

tpantelis pushed a commit to submariner-io/releases that referenced this issue


          Bump tim-actions/commit-message for Node.js update

e618e9a

Bump to the latest commit, which updates node from 12 to 16.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

tpantelis pushed a commit to submariner-io/releases that referenced this issue


          Bump tim-actions/get-pr-commits for Node.js update

f0c8423

Bump to the latest commit, which updates node from 12 to 16 in addition
to an actions/core update.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

tpantelis pushed a commit to submariner-io/cloud-prepare that referenced this issue


          Bump tim-actions/get-pr-commits for Node.js update

d4c2c22

Bump to the latest commit, which updates node from 12 to 16 in addition
to an actions/core update.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

tpantelis pushed a commit to submariner-io/cloud-prepare that referenced this issue


          Bump tim-actions/commit-message for Node.js update

70b03e5

Bump to the latest commit, which updates node from 12 to 16.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

tpantelis pushed a commit to submariner-io/shipyard that referenced this issue


          Bump tim-actions/commit-message for Node.js update

dcabf73

Bump to the latest commit, which updates node from 12 to 16.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

tpantelis pushed a commit to submariner-io/shipyard that referenced this issue


          Bump tim-actions/get-pr-commits for Node.js update

53d410d

Bump to the latest commit, which updates node from 12 to 16 in addition
to an actions/core update.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

tpantelis pushed a commit to submariner-io/shipyard that referenced this issue


          Bump tim-actions/commit-message for Node.js update

b3a3a1f

Bump to the latest commit, which updates node from 12 to 16.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

tpantelis pushed a commit to submariner-io/shipyard that referenced this issue


          Bump tim-actions/get-pr-commits for Node.js update

b473561

Bump to the latest commit, which updates node from 12 to 16 in addition
to an actions/core update.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

tpantelis pushed a commit to submariner-io/shipyard that referenced this issue


          Bump tim-actions/get-pr-commits for Node.js update

dc0c5c9

Bump to the latest commit, which updates node from 12 to 16 in addition
to an actions/core update.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

tpantelis pushed a commit to submariner-io/shipyard that referenced this issue


          Bump tim-actions/commit-message for Node.js update

Bump to the latest commit, which updates node from 12 to 16.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

tpantelis pushed a commit to submariner-io/lighthouse that referenced this issue


          Bump tim-actions/commit-message for Node.js update

e7ec727

Bump to the latest commit, which updates node from 12 to 16.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

tpantelis pushed a commit to submariner-io/lighthouse that referenced this issue


          Bump tim-actions/get-pr-commits for Node.js update

3842e35

Bump to the latest commit, which updates node from 12 to 16 in addition
to an actions/core update.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

tpantelis pushed a commit to submariner-io/lighthouse that referenced this issue


          Bump tim-actions/commit-message for Node.js update

d6af214

Bump to the latest commit, which updates node from 12 to 16.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

tpantelis pushed a commit to submariner-io/lighthouse that referenced this issue


          Bump tim-actions/get-pr-commits for Node.js update

5b4c35a

Bump to the latest commit, which updates node from 12 to 16 in addition
to an actions/core update.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

tpantelis pushed a commit to submariner-io/lighthouse that referenced this issue


          Bump tim-actions/commit-message for Node.js update

c764020

Bump to the latest commit, which updates node from 12 to 16.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

tpantelis pushed a commit to submariner-io/lighthouse that referenced this issue


          Bump tim-actions/get-pr-commits for Node.js update

78927a7

Bump to the latest commit, which updates node from 12 to 16 in addition
to an actions/core update.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

Member

dfarrell07 commented Apr 17, 2023

All the backports are merged, this is done. ✔️

dfarrell07 closed this as completed

novad03 pushed a commit to novad03/k8s-submariner that referenced this issue


          Bump tim-actions/get-pr-commits for Node.js update

5c4d24f

Bump to the latest commit, which updates node from 12 to 16 in addition
to an actions/core update.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

novad03 pushed a commit to novad03/k8s-submariner that referenced this issue


          Bump tim-actions/commit-message for Node.js update

17ce9ca

Bump to the latest commit, which updates node from 12 to 16.

Relates-to: submariner-io/subctl#537
Signed-off-by: Daniel Farrell <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment