-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump github.com/golangci/golangci-lint from 1.60.1 to 1.60.3 in /tools in the tools group #1715
Bump github.com/golangci/golangci-lint from 1.60.1 to 1.60.3 in /tools in the tools group #1715
Conversation
8e5704b
to
ebe92c2
Compare
I've submitted PRs in other projects to address the linting errors. This needs to be submitted first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description in the last commit is incorrect.
As a general rule, I prefer to describe the change in the commit message, rather than say it’s a golangci-lint fix — the fix is valid whether or not it handles an issue identified by golangci-lint. So “Fix a number of overflowing integer conversions” for example for the first commit. The third commit is golangci-lint-specific 😉
There actually shouldn't have been 2 commits - not sure how that happened. I'll just combine one and three. The third commit is technically a golangci-lint fix b/c the linter is deprecated. |
Bumps the tools group in /tools with 1 update: [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint). Updates `github.com/golangci/golangci-lint` from 1.60.1 to 1.60.3 - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.60.1...v1.60.3) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-patch dependency-group: tools ... Signed-off-by: dependabot[bot] <[email protected]>
Specifically, gosec "integer overflow conversion" issues. Signed-off-by: Tom Pantelis <[email protected]>
Signed-off-by: Tom Pantelis <[email protected]>
ebe92c2
to
59e4750
Compare
Bumps the tools group in /tools with 1 update: github.com/golangci/golangci-lint.
Updates
github.com/golangci/golangci-lint
from 1.60.1 to 1.60.3Release notes
Sourced from github.com/golangci/golangci-lint's releases.
Changelog
Sourced from github.com/golangci/golangci-lint's changelog.
Commits
c2e095c
build(deps): bump github.com/securego/gosec/v2 from 81cda2f91fbe to ab3f6c1c8...f0c1904
feat: check that Go version use to build is greater or equals to the Go versi...2f53f2c
docs: update documentation (#4931)1bdd38b
docs: update documentation assets (#4930)561049d
docs: update GitHub Action assets (#4929)f338f3e
build(deps): bump github.com/securego/gosec/v2 from 5f0084eb01a9 to 81cda2f91...741df1f
dev: fix GO_VERSION in post release workflow (#4926)87dd8fe
exportloopref: deprecation (#4916)af298e1
chore: update gofmt (#4923)132d81c
build(deps): bump github.com/tomarrell/wrapcheck/v2 from 2.8.3 to 2.9.0 (#4921)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditions