Lint all Go modules #1554
Merged
Lint all Go modules #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skitt
requested review from
mkolesnik,
Oats87,
sridhargaddam,
tpantelis and
vthapar
as code owners
|
🤖 Created branch: z_pr1554/skitt/lint-submodules |
vthapar
approved these changes
Feb 12, 2024
dfarrell07
approved these changes
Feb 13, 2024
In projects with multiple modules, Shipyard's linting rule ends up ignoring all but the main module. To find all modules which need to be analysed, this looks for directories containing a file named go.mod and *.go files declaring functions. Running golangci-lint on multiple modules now requires a workspace covering the modules, so this is set up before the linter invocation. Signed-off-by: Stephen Kitt <[email protected]>
skitt
force-pushed
the
lint-submodules
branch
from
ef4c22b to
f2b29ec
Compare
|
This PR/issue depends on:
|
|
🤖 Closed branches: [z_pr1554/skitt/lint-submodules] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In projects with multiple modules, Shipyard's linting rule ends up ignoring all but the main module. To find all modules which need to be analysed, this looks for directories containing a file named go.mod and *.go files declaring functions.
Depends on submariner-io/lighthouse#1505