Refactor Shipyard to be consumable by other projects #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Created branch: z_pr1497/mkolesnik/remixed |
mkolesnik
force-pushed
the
remixed
branch
6 times, most recently
from
bca49e5 to
4a9aa75
Compare
mkolesnik
force-pushed
the
remixed
branch
2 times, most recently
from
90b7d99 to
45a6dd9
Compare
mkolesnik
changed the title
mkolesnik
changed the title
mkolesnik
requested review from
Oats87,
skitt,
sridhargaddam,
tpantelis and
dfarrell07
as code owners
skitt
requested changes
Dec 22, 2023
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further |
Make base dapper logic project agnostic so that it can be consumed by projects outside the submariner org. This mainly involves moving out basic dapper functions out to `Makefile.dapper.base` and adding an `ORG` argument to specify the organization. References to `submariner-io` have been removed where possible. Signed-off-by: Mike Kolesnik <[email protected]>
To make it easy for other projects to consume, split out linting to a `Makefile.linting` file that can be included by other projects that desire these capabilities. Signed-off-by: Mike Kolesnik <[email protected]>
To make it easy for other projects to consume, split out cluster creation and cleanup to a `Makefile.clusters` file that can be included by other projects that desire these capabilities. Signed-off-by: Mike Kolesnik <[email protected]>
To better support external projects, rename the flag to a more neutral one which actually reflects the type of deployment. The old flag (when sent via `using=`) is still respected, to not break existing Submariner projects. Signed-off-by: Mike Kolesnik <[email protected]>
For easier consumption from other projects, and for easier POCs, make the URL and image locations dynamic so that we can specify where to take base Shipyard files and images from. Signed-off-by: Mike Kolesnik <[email protected]>
Since the workaround is Submariner specific, it should be part of the deploy stage and not part of the cluster creation stage which is agnostic to Submariner. Signed-off-by: Mike Kolesnik <[email protected]>
Add the option to run just Shipyard's goals inside the container, to not interfere with consuming project's goals. Currently, this only covers the basic clusters and Go linting goals, but more goals can be added in the future. Signed-off-by: Mike Kolesnik <[email protected]>
Add an ability to specify custom config in the cluster config file, which will be provider specific, and allow consuming projects to customize the provider's configuration before deploying. Currently, only 'kind' will be supported. Signed-off-by: Mike Kolesnik <[email protected]>
skitt
approved these changes
Jan 22, 2024
tpantelis
approved these changes
Jan 23, 2024
|
🤖 Closed branches: [z_pr1497/mkolesnik/remixed] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits refactor Shipyard and break it down into smaller more basic components which are Submariner agnostic.
This allows it to be used in projects outside the Submariner org, i.e. skupperproject/skupper#1317