-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update krew-index on release tag #911
Conversation
🤖 Created branch: z_pr911/tpantelis/krew_update |
57acd0d
to
a5d9847
Compare
I'm not sure if there's a way to actually test the new GHA now but, once merged, we should be able to manually trigger it from the Actions tab for the 0.16.3 release tag. |
See the GHA docs:
in the releases project (for v0.17.0-rc0). This produces the index which would be pushed to update the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would fix the job, but there’s a more general problem I think we need to address before we get things working on all releases: since we can only publish one version of the subm
plugin, we need to ensure that (a) we only publish actual releases (not rcs etc.) and (b) we only publish the latest release on the latest branch.
The krew-release-bot takes care of that: "If a release is marked as a 'prerelease' in github, it will not be released to the krew index.".
I was thinking about that too. I'm not sure how we can do that.... |
yeah that will test the .krew.yaml file but not the GHA. |
Ah yes, and we mark them correctly already. |
Fixes submariner-io#904 Signed-off-by: Tom Pantelis <[email protected]>
a5d9847
to
02b4cf3
Compare
I found a way to get the release tag marked as the latest. |
🤖 Closed branches: [z_pr911/tpantelis/krew_update] |
Fixes #904