Update quic-go to 0.42.0 for CVE-2024-22189 #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfarrell07
requested review from
aswinsuryan,
maayanf24,
Oats87,
skitt,
sridhargaddam,
tpantelis,
vthapar and
yboaron
as code owners
|
🤖 Created branch: z_pr1541/dfarrell07/quic_16 |
Generated by: go get github.com/quic-go/[email protected] go get toolchain@none go mod tidy Signed-off-by: Daniel Farrell <[email protected]>
|
I'm not sure about the best way to handle the new-ish toolchain directive. It would be added by this bump, as this quic-go update requires golang 1.21 which adds the feature by default. However, the toolchain would be set to my local golang version, which seems pretty arbitrary. That would force go commands for this repo to use my version. It should happen seamlessly behind the scenes, but it still seems undesirable to set an arbitrary constraint. |
skitt
approved these changes
Apr 16, 2024
tpantelis
approved these changes
Apr 16, 2024
|
🤖 Closed branches: [z_pr1541/dfarrell07/quic_16] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated by:
go get github.com/quic-go/[email protected]
go get toolchain@none
go mod tidy