Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use shipyard framework By instead of ginkgo By #1538

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Use shipyard framework By instead of ginkgo By #1538

merged 2 commits into from
Apr 3, 2024

Conversation

tpantelis
Copy link
Contributor

This alows flexibility to format or omit the output.

Related to submariner-io/subctl#131

@tpantelis tpantelis self-assigned this Apr 2, 2024
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr1538/tpantelis/use_framework_by
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@tpantelis tpantelis changed the title Use shipyard framework By instaed of ginkgo By Use shipyard framework By instead of ginkgo By Apr 2, 2024
@tpantelis
Use shipyard framework By instead of ginkgo By
4eaf283 
This alows flexibility to format or omit the output.

Related to submariner-io/subctl#131

Signed-off-by: Tom Pantelis <[email protected]>
skitt
skitt approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@skitt skitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth noting that by default, tests run using RunE2ETests set By up so that it calls ginkgo’s By, so this doesn’t change existing behaviour.

@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Apr 2, 2024
@tpantelis
Copy link
Contributor Author

It might be worth noting that by default, tests run using RunE2ETests set By up so that it calls ginkgo’s By, so this doesn’t change existing behaviour.

No - this is for subctl verify.

@skitt
Copy link
Member

skitt commented Apr 2, 2024

It might be worth noting that by default, tests run using RunE2ETests set By up so that it calls ginkgo’s By, so this doesn’t change existing behaviour.

No - this is for subctl verify.

Right, I get that the context of this change is subctl verify; but in each project where changes are being made, it also affects the E2E output. All I’m saying is that as far as E2E is concerned the change is innocuous because the framework sets By and Fail up to call the ginkgo functions in that scenario.

@skitt skitt merged commit 89e79c3 into submariner-io:devel Apr 3, 2024
23 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr1538/tpantelis/use_framework_by]

@tpantelis tpantelis deleted the use_framework_by branch August 19, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skitt skitt skitt approved these changes

@dfarrell07 dfarrell07 dfarrell07 approved these changes

@aswinsuryan aswinsuryan Awaiting requested review from aswinsuryan aswinsuryan is a code owner

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@sridhargaddam sridhargaddam Awaiting requested review from sridhargaddam sridhargaddam is a code owner

@vthapar vthapar Awaiting requested review from vthapar vthapar is a code owner

Assignees

@tpantelis tpantelis

Labels
ready-to-test When a PR is ready for full E2E testing
Projects
No open projects
Submariner 0.18
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tpantelis @submariner-bot @skitt @dfarrell07