Only fail builds for high+ vulns #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the vulnerability scan doesn't distinguish between vulnerabilities added by the PR and those coming from vulnerability updates, PRs are regularly blocked because of unrelated vulnerabilities. Arguably this is desirable for important vulnerabilities since it forces them to be handled; but other vulnerabilities shouldn't block PRs. This changes the fail threshold to high, so that only vulnerabilities with severity high or critical will block the build. Signed-off-by: Stephen Kitt <[email protected]>
skitt
requested review from
aswinsuryan,
mkolesnik,
Oats87,
sridhargaddam,
tpantelis and
vthapar
as code owners
sridhargaddam
approved these changes
Mar 11, 2024
|
🤖 Created branch: z_pr1517/skitt/fail-on-high-vulns |
tpantelis
approved these changes
Mar 11, 2024
|
🤖 I had an issue pushing the updated branch: dial tcp: lookup github.com on 172.30.0.10:53: read udp 10.128.4.12:47556->172.30.0.10:53: i/o timeout |
vthapar
approved these changes
Mar 18, 2024
This was referenced Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the vulnerability scan doesn't distinguish between vulnerabilities added by the PR and those coming from vulnerability updates, PRs are regularly blocked because of unrelated vulnerabilities. Arguably this is desirable for important vulnerabilities since it forces them to be handled; but other vulnerabilities shouldn't block PRs.
This changes the fail threshold to high, so that only vulnerabilities with severity high or critical will block the build.