Fix invalid ServiceExport Conflict status condition #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpantelis
requested review from
aswinsuryan,
Oats87,
skitt,
sridhargaddam and
vthapar
as code owners
|
🤖 Created branch: z_pr1439/tpantelis/port_conflict_issue |
aswinsuryan
approved these changes
Nov 17, 2023
sridhargaddam
approved these changes
Nov 17, 2023
This occurs if there's more than one service exported in a cluster. The conflict checking was processing all local EndpointSlices instead of only those corresponding to the service in question. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
force-pushed
the
port_conflict_issue
branch
from
2b62b61 to
4da724c
Compare
|
🤖 Closed branches: [z_pr1439/tpantelis/port_conflict_issue] |
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Nov 17, 2023
Release notes for submariner-io/lighthouse#1439 Signed-off-by: Tom Pantelis <[email protected]>
skitt
pushed a commit
to submariner-io/submariner-website
that referenced
this pull request
Nov 20, 2023
Release notes for submariner-io/lighthouse#1439 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Nov 20, 2023
Release notes for submariner-io/lighthouse#1439 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Nov 20, 2023
Release notes for submariner-io/lighthouse#1439 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Nov 20, 2023
Release notes for submariner-io/lighthouse#1439 Signed-off-by: Tom Pantelis <[email protected]>
skitt
pushed a commit
to submariner-io/submariner-website
that referenced
this pull request
Nov 21, 2023
Release notes for submariner-io/lighthouse#1439 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Jan 11, 2024
Release notes for submariner-io/lighthouse#1439 Signed-off-by: Tom Pantelis <[email protected]>
aswinsuryan
pushed a commit
to submariner-io/submariner-website
that referenced
this pull request
Jan 11, 2024
Release notes for submariner-io/lighthouse#1439 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Feb 27, 2024
Release notes for submariner-io/lighthouse#1439 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to submariner-io/submariner-website
that referenced
this pull request
Feb 29, 2024
Release notes for submariner-io/lighthouse#1439 Signed-off-by: Tom Pantelis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This occurs if there's more than one service exported in a cluster. The conflict checking was processing all local
EndpointSlicesinstead of only those corresponding to the service in question.