Reduce string constant duplication #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skitt
requested review from
aswinsuryan,
Oats87,
sridhargaddam,
tpantelis and
vthapar
as code owners
|
🤖 Created branch: z_pr1410/skitt/string-consts |
Newer versions of goconst detect more instances of string duplication, in particular ".svc." in Lighthouse. Address that by providing a framework function to construct a service's DNS name based on its components. A few string constants aren't actually shared, remove them to improve code clarity. Signed-off-by: Stephen Kitt <[email protected]>
tpantelis
approved these changes
Oct 24, 2023
Signed-off-by: Thomas Pantelis <[email protected]>
vthapar
approved these changes
Oct 25, 2023
|
🤖 Closed branches: [z_pr1410/skitt/string-consts] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of goconst detect more instances of string duplication, in particular ".svc." in Lighthouse. Address that by providing a framework function to construct a service's DNS name based on its components.
A few string constants aren't actually shared, remove them to improve code clarity.