Use envconfig for all SUBMARINER_ variables #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skitt
requested review from
aswinsuryan,
Oats87,
sridhargaddam,
tpantelis and
vthapar
as code owners
|
🤖 Created branch: z_pr1409/skitt/envconfig-everything |
tpantelis
approved these changes
Oct 24, 2023
sridhargaddam
approved these changes
Oct 25, 2023
vthapar
approved these changes
Oct 26, 2023
In the Lighthouse agent, logging settings are specified using SUBMARINER_ variables but parsed manually. Since envconfig is used for all other SUBMARINER_ variables, extend it to cover these settings as well. Signed-off-by: Stephen Kitt <[email protected]>
tpantelis
force-pushed
the
envconfig-everything
branch
from
ed6dd54 to
bbae0f8
Compare
|
🤖 Closed branches: [z_pr1409/skitt/envconfig-everything] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Lighthouse agent, logging settings are specified using SUBMARINER_ variables but parsed manually. Since envconfig is used for all other SUBMARINER_ variables, extend it to cover these settings as well.