Alleviate excessive periodic logging during conflict check #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpantelis
requested review from
aswinsuryan,
Oats87,
skitt,
sridhargaddam and
vthapar
as code owners
|
🤖 Created branch: z_pr1400/tpantelis/excess_logging |
skitt
approved these changes
Oct 4, 2023
If a service is imported without a local service export, the conflict checking tries to update the status of a non-existent ServiceExport, specifically to remove the Conflict status condition. This results in a log message: "ServiceExport (...) not found - unable to update status" Due to the 2 minute resync intervaL for the EndpointSlice syncer, this can exhaust the pod disk storage over time. To alleviate this issue, check the local cache for a ServiceExport and, if non-existent, skip the conflict checking. If it does exist but the Conflict status condition doesn't exist in the local ServiceExport then elide trying to remove the status condition. Finally, change the log level to TRACE for the offending message. Signed-off-by: Tom Pantelis <[email protected]>
Use the local cache to list the EndpointSlices instead of the API server client. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
force-pushed
the
excess_logging
branch
from
05d9965 to
0f474aa
Compare
aswinsuryan
approved these changes
Oct 4, 2023
sridhargaddam
approved these changes
Oct 5, 2023
|
🤖 Closed branches: [z_pr1400/tpantelis/excess_logging] |
|
Do we want to backport this PR? |
I think so, I’ve taken care of it — if there are objections feel free to raise them on the backport PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a service is imported without a local service export, the conflict checking tries to update the status of a non-existent
ServiceExport, specifically to remove the Conflict status condition. This results in a log message: ServiceExport (...) not found - unable to update statusDue to the 2 minute resync intervaL for the
EndpointSlicesyncer, this can exhaust the pod disk storage over time.(first commit) To alleviate this issue, check the local cache for a ServiceExport and, if non-existent, skip the conflict checking. If it does exist but the Conflict status condition doesn't exist in the local ServiceExport then elide trying to remove the status condition. Also, change the log level to TRACE for the offending message.
(second commit) Optimize conflict checking using the local cache to list the
EndpointSlicesinstead of the API server client.