Implement ServiceImport aggregation #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpantelis
requested review from
skitt,
sridhargaddam and
vthapar
as code owners
|
🤖 Created branch: z_pr1144/tpantelis/si_aggregate |
tpantelis
force-pushed
the
si_aggregate
branch
19 times, most recently
from
a7d097f
to
9bfe974
Compare
tpantelis
force-pushed
the
si_aggregate
branch
3 times, most recently
from
9e01f56
to
a0d2576
Compare
Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
force-pushed
the
si_aggregate
branch
3 times, most recently
from
33358c2
to
bf4673f
Compare
|
Doesn't this depend on submariner-io/admiral#572 too? |
It didn't really need to but now that's it's been merged I can remove pending from the test. |
- A local ServiceImport is still created in the submariner NS from the ServiceExport as before to decouple it from the broker syncing. - The local service information is merged into an aggregated ServiceImport on the broker in two stages. First, a resource syncer that watches for local ServiceImports creates the aggregated ServiceImport with no service info using a custom Federator. This will also check for service type conflict if the aggregated ServiceImport already exists. On success, the Endpoints controller is started. The local service information is merged into the aggregated ServiceImport after the local EndpointSlice is created and synced to the broker. This is done b/c the aggregated port information is determined from the constituent clusters' EndpointSlices, thus each cluster must have a consistent view of all the EndpointSlices in order for the aggregated port information to be eventually consistent. - The aggregated ServiceImports from the broker are synced to the local service NS. - The local EndpointSlice for non-headless now creates a single Endpoint with the service IP. It's Ready condition is set to based on the availability of the backend pod IPs. TODO: - Merging ports in the aggregated ServiceImport from the constituent clusters for non-headless. - Service type and port conflict detection. - Migration of legacy per-cluster ServiceImports. Signed-off-by: Tom Pantelis <[email protected]>
The aggregated ServiceImport is only used to obtain the headlesness of the service. The rest of the per-cluster info, ie service IP and ports, is obtained from the EndpointSlices. For migration, it still processes legacy cluster ServiceImports and EndpointSlices to support non-upgraded clusters during a rolling upgrade. For the former, the service IP is used as before and the latter is only used to determine the health of the endpoints. Signed-off-by: Tom Pantelis <[email protected]>
Signed-off-by: Tom Pantelis <[email protected]>
|
This PR/issue depends on:
|
aswinsuryan
reviewed
Mar 24, 2023
aswinsuryan
reviewed
Mar 24, 2023
aswinsuryan
approved these changes
Mar 24, 2023
vthapar
approved these changes
Mar 27, 2023
|
🤖 Closed branches: [z_pr1144/tpantelis/si_aggregate] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two main commits: the first to implement
ServiceImportaggregation in the agent controller and the second to use the aggregatedServiceImportsin the CoreDNS plugin. See commits for details.There's still remaining work described as TODOs in the commits that will be completed in subsequent PRs.
Related to #214
Depends on submariner-io/admiral#571