Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-duplicate EndpointSlice endpoints #1322

Closed
tpantelis opened this issue Jul 29, 2023 · 1 comment · Fixed by #1482
Closed

De-duplicate EndpointSlice endpoints #1322

tpantelis opened this issue Jul 29, 2023 · 1 comment · Fixed by #1482
Assignees
@tpantelis
Labels
priority:low scale

Comments

@tpantelis
Copy link
Contributor

As outlined here, duplicate endpoints are possible with K8s EndpointSlices. We should de-duplicate them in the coredns plugin.
@tpantelis tpantelis self-assigned this Jul 29, 2023
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further
activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 30, 2023
@tpantelis tpantelis removed the stale label Nov 30, 2023
@tpantelis tpantelis mentioned this issue Dec 12, 2023
Merged
@tpantelis tpantelis moved this from Todo to In Progress in Submariner 0.17 Jan 19, 2024
tpantelis added a commit to tpantelis/lighthouse that referenced this issue Jan 19, 2024
@tpantelis
De-duplicate EndpointSlice endpoint addresses in the resolver
e5c8f38 
Fixes submariner-io#1322

Signed-off-by: Tom Pantelis <[email protected]>
@tpantelis tpantelis moved this from In Progress to In Review in Submariner 0.17 Jan 19, 2024
@tpantelis tpantelis mentioned this issue Jan 19, 2024
Merged
tpantelis added a commit to tpantelis/lighthouse that referenced this issue Jan 19, 2024
@tpantelis
De-duplicate EndpointSlice endpoint addresses in the resolver
0a90b75 
Fixes submariner-io#1322

Signed-off-by: Tom Pantelis <[email protected]>
sridhargaddam pushed a commit that referenced this issue Jan 22, 2024
@tpantelis @sridhargaddam
De-duplicate EndpointSlice endpoint addresses in the resolver
be6e729 
Fixes #1322

Signed-off-by: Tom Pantelis <[email protected]>
@github-project-automation github-project-automation bot moved this from In Review to Done in Submariner 0.17 Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tpantelis tpantelis

Labels
priority:low scale
Projects
No open projects
Submariner 0.17
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

De-duplicate EndpointSlice endpoint addresses in the resolver tpantelis/lighthouse
2 participants
@dfarrell07 @tpantelis