Disable unparam linting on test files

Parameters getting the same value in all (current) uses isn't significant. Signed-off-by: Stephen Kitt <[email protected]>
submariner-io · Feb 13, 2024 · d236364 · d236364
1 parent 9752fb3
commit d236364
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -156,4 +156,5 @@ issues:
       linters:
         - gochecknoinits
         - goerr113
+        - unparam
         - wrapcheck
diff --git a/coredns/plugin/handler_test.go b/coredns/plugin/handler_test.go
@@ -992,7 +992,6 @@ func (t *handlerTestDriver) executeTestCase(rec *dnstest.Recorder, tc test.Case)
 	}
 }
 
-//nolint:unparam // `name` always receives `service1'.
 func newServiceImport(namespace, name string, siType mcsv1a1.ServiceImportType) *mcsv1a1.ServiceImport {
 	return &mcsv1a1.ServiceImport{
 		ObjectMeta: metav1.ObjectMeta{
@@ -1005,7 +1004,6 @@ func newServiceImport(namespace, name string, siType mcsv1a1.ServiceImportType)
 	}
 }
 
-//nolint:unparam // `namespace` always receives `namespace1`.
 func newEndpointSlice(namespace, name, clusterID string, ports []mcsv1a1.ServicePort, endpoints ...discovery.Endpoint,
 ) *discovery.EndpointSlice {
 	epPorts := make([]discovery.EndpointPort, len(ports))