-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple active gateway enhancement proposal #69
Conversation
🤖 Created branch: z_pr69/anfredette/multi-gateway |
397e0b3
to
dfe5c07
Compare
Thanks for your feedback @astoycos! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a general comment about this proposal: based on user's feedback so far, it's not clear if the gateway model (where we assume that dedicated nodes or certain worker nodes have public IPs available) is really the future of Submariner. This model is not very cloud-native, cumbersome to setup, and is not compatible/realistic with many of the managed Kubernetes offerings which are becoming more popular. For this reason, we started some early exploration work around using a LoadBalancer
type service instaed (see also https://submariner.io/getting-started/architecture/gateway-engine/). I am wondering if we shouldn't complete the investigation of the LoadBalancer
mode first, before further investing into HA of the gateway model.
+1 |
+1 to @nyechiel's assessment. Additionally, LB mode would have many of the problems of multiple gateways (since we'd probably want to run more than one GW pod). |
submariner-io#69 Signed-off-by: Andre Fredette <[email protected]> Co-authored-by: Andrew Stoycos <[email protected]> Co-authored-by: Billy McFall <[email protected]>
953b3d2
to
66e5834
Compare
Thanks everyone for the review and comments/suggestions. We've updated the proposal to reflect our current thoughts on the design, and the POC that has been implemented. We're currently doing some performance testing and will update the pr when we get some results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added updates based on the Tech Exchange. Also added some PoC details.
submariner-io#69 Signed-off-by: Andre Fredette <[email protected]> Co-authored-by: Andrew Stoycos <[email protected]> Co-authored-by: Billy McFall <[email protected]>
7534a5c
to
61f4de9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that the open-items/limitations discussed during the tech-exchange session are added as TODO/Notes in the PR. LGTM, thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see concerns are listed as TODO, so we can merge as "Deferred", with the intention that should this be picked up in the future the entire EP will have to be re-reviewed.
Submariner currently only allows a single gateway to be active at any one time in a given cluster. This enhancement proposes that there be an option to allow more than one gateway to be active in a given cluster to enhance both performance and resiliency. This feature is sometimes referred to as “active-active gateways”; however, the goal is to allow two or more actove gateways to be used. Signed-off-by: Andre Fredette <[email protected]>
Signed-off-by: Andre Fredette <[email protected]>
submariner-io#69 Signed-off-by: Andre Fredette <[email protected]> Co-authored-by: Andrew Stoycos <[email protected]> Co-authored-by: Billy McFall <[email protected]>
based on design review and other discussions Signed-off-by: Andre Fredette <[email protected]> Co-authored-by: Billy McFall <[email protected]> Co-authored-by: Andrew Stoycos <[email protected]>
fc47948
to
bd57b72
Compare
@sridhargaddam, I think this is good to merge now, isn't it? Thanks, Andre |
Indeed, thank you @anfredette |
🤖 Closed branches: [z_pr69/anfredette/multi-gateway] |
Thanks, @sridhargaddam! |
Submariner currently only allows a single gateway to be active at
any one time in a given cluster. This enhancement proposes that
there be an option to allow more than one gateway to be active in
a given cluster to enhance both performance and resiliency. This
feature is sometimes referred to as “active-active gateways”;
however, the goal is to allow two or more active gateways to be used.
Signed-off-by: Andre Fredette [email protected]