Fix AWS cloud prepare to support OCP 4.16 new naming convention #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Created branch: z_pr949/aswinsuryan/fix-aws-prepare |
aswinsuryan
force-pushed
the
fix-aws-prepare
branch
29 times, most recently
from
da0ba02
to
644f60f
Compare
yboaron
reviewed
Jun 19, 2024
yboaron
reviewed
Jun 19, 2024
yboaron
reviewed
Jun 19, 2024
tpantelis
requested changes
Jun 19, 2024
aswinsuryan
force-pushed
the
fix-aws-prepare
branch
2 times, most recently
from
9864c2b
to
2969d3a
Compare
tpantelis
requested changes
Jun 19, 2024
aswinsuryan
force-pushed
the
fix-aws-prepare
branch
from
2969d3a
to
44cb1f7
Compare
yboaron
reviewed
Jun 20, 2024
yboaron
reviewed
Jun 20, 2024
aswinsuryan
force-pushed
the
fix-aws-prepare
branch
from
44cb1f7
to
315f4fe
Compare
yboaron
approved these changes
Jun 20, 2024
tpantelis
approved these changes
Jun 20, 2024
aswinsuryan
force-pushed
the
fix-aws-prepare
branch
6 times, most recently
from
b213c29
to
36f3aac
Compare
aswinsuryan
commented
Jun 21, 2024
OCP 4.16 has a new naming convnention, so cloud prepare is enhanced to support both old and new formats. Signed-off-by: Aswin Suryanarayanan <[email protected]>
Signed-off-by: Aswin Suryanarayanan <[email protected]>
aswinsuryan
force-pushed
the
fix-aws-prepare
branch
from
36f3aac
to
4b695fc
Compare
vthapar
approved these changes
Jun 21, 2024
|
🤖 Closed branches: [z_pr949/aswinsuryan/fix-aws-prepare] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCP 4.16 has a new naming convnention, so cloud prepare is
enhanced to support both old and new formats.