CreateOrUpdate should only update status if it is specified #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We saw an issue with a K8s Deployment where the existing resource had a status field and the new resource had an empty status field but CreateOrUpdate still tried to update the status which led to an eventual conflict failure due to retries exhausted. The reason for this is that it merely compares the original and new statuses for equality. We should first check if the new status is even specified. In addition: - Removed the UpdateStatusFunc from the K8s resource.Interface implementations (Deployment, DaemonSet et al). The K8s controllers own the status for these resources and we should never be updating it. - Added a resource.ToJSON function to provide a more user-frendly output then the default Go object stringer. Also JSON outputs pointer values rather than their addresses.. Signed-off-by: Tom Pantelis <[email protected]>
|
🤖 Created branch: z_pr580/tpantelis/fix_update_status |
|
You have successfully added a new Grype configuration |
vthapar
approved these changes
Mar 28, 2023
skitt
approved these changes
Mar 28, 2023
|
🤖 Closed branches: [z_pr580/tpantelis/fix_update_status] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We saw an issue with a K8s
Deploymentwhere the existing resource had a status field and the new resource had an empty status field butCreateOrUpdatestill tried to update the status which led to an eventual conflict failure due to retries exhausted. The reason for this is that it merely compares the original and new statuses for equality. We should first check if the new status is even specified.In addition:
Removed the
UpdateStatusFuncfrom the K8s resource.Interface implementations (Deployment,DaemonSetet al). The K8s controllers own the status for these resources and we should never be updating it.Added a
resource.ToJSONfunction to provide a more user-frendly output then the default Go object stringer. Also JSON outputs pointer values rather than their addresses..