[HTML] Add support for mime type completions #4061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit... 1. scopes `type="..."` attributes with unique `meta.attribute-with-value.type` 2. adds basic completions for known mime types. This change is probably of lower importance for basic HTML, but this change may help improving DX for template languages, which support more mime types like TypeScript, LiveScript, Babel, CoffeScript, ... .
keith-hall
previously approved these changes
Oct 21, 2024
keith-hall
approved these changes
Oct 21, 2024
michaelblyons
approved these changes
Oct 21, 2024
deathaxe
added a commit
to SublimeText/CoffeeScript
that referenced
this pull request
Oct 31, 2024
This commit... 1. adds `language` to list of supported tag attributes used to detect script language. 2. adds dedicated meta scopes for `lang` and `type` attributes 3. adds completions for those values. Follows sublimehq/Packages#4061
deathaxe
added a commit
to SublimeText/Astro
that referenced
this pull request
Nov 2, 2024
deathaxe
added a commit
to SublimeText/Astro
that referenced
this pull request
Nov 2, 2024
This commit scopes `lang` and `language` attributes special to enable static lang value completions. Related with sublimehq/Packages#4061
deathaxe
added a commit
to SublimeText/Astro
that referenced
this pull request
Nov 2, 2024
This commit scopes `type` attributes special to enable static type value completions and adjusts some tests to maintain compatibility with older ST builds. Related with sublimehq/Packages#4061
deathaxe
added a commit
to deathaxe/Svelte
that referenced
this pull request
Nov 22, 2024
This commit scopes `lang=""` attributes `meta.attribute-with-value.lang` and `type=""` attributes `meta.attribute-with-value.type`, to enable support for language/mime-type value completions. Note: mime-type completions require ST release with following PR merged. related with sublimehq/Packages#4061
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR...
type="..."attributes with uniquemeta.attribute-with-value.typeThis change is probably of lower importance for basic HTML, but this change may help improving DX for template languages, which support more mime types like TypeScript, LiveScript, Babel, CoffeScript, ... .