Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JavaScript] Basic support for syntax highlighting in tagged templates #4019

Merged
merged 5 commits into from
Jul 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions JavaScript/Embeddings/CSS (for JS template).sublime-syntax
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
%YAML 1.2
---
# http://www.sublimetext.com/docs/syntax.html
# highlight tagged template strings
scope: source.css.js-template
version: 2
hidden: true

extends: Packages/CSS/CSS.sublime-syntax

variables:

ident_start: (?:{{nmstart}}|\${)

contexts:

prototype:
- meta_prepend: true
- include: scope:source.js#text-interpolations

strings-content:
- meta_prepend: true
- include: scope:source.js#string-interpolations
122 changes: 122 additions & 0 deletions JavaScript/Embeddings/HTML (for JS template).sublime-syntax
Original file line number Diff line number Diff line change
@@ -0,0 +1,122 @@
%YAML 1.2
---
# http://www.sublimetext.com/docs/syntax.html
# highlight tagged template strings
scope: text.html.js-template
version: 2
hidden: true

extends: Packages/HTML/HTML.sublime-syntax

variables:

tag_name_start: (?:[A-Za-z]|\${)

contexts:

prototype:
- meta_prepend: true
- include: scope:source.js#text-interpolations

cdata-content:
- meta_prepend: true
- include: scope:source.js#string-interpolations

script-javascript-content:
- meta_include_prototype: false
- match: '{{script_content_begin}}'
captures:
1: comment.block.html punctuation.definition.comment.begin.html
pop: 1 # make sure to match only once
embed: scope:source.js.js-template
embed_scope: source.js.embedded.html
escape: '{{script_content_end}}'
escape_captures:
1: source.js.embedded.html
2: comment.block.html punctuation.definition.comment.end.html
3: source.js.embedded.html
4: comment.block.html punctuation.definition.comment.end.html

script-json-content:
- meta_include_prototype: false
- match: '{{script_content_begin}}'
captures:
1: comment.block.html punctuation.definition.comment.begin.html
pop: 1 # make sure to match only once
embed: scope:source.json.js-template
embed_scope: source.json.embedded.html
escape: '{{script_content_end}}'
escape_captures:
1: source.json.embedded.html
2: comment.block.html punctuation.definition.comment.end.html
3: source.json.embedded.html
4: comment.block.html punctuation.definition.comment.end.html

style-css-content:
- meta_include_prototype: false
- match: '{{style_content_begin}}'
captures:
1: comment.block.html punctuation.definition.comment.begin.html
pop: 1 # make sure to match only once
embed: scope:source.css.js-template
embed_scope: source.css.embedded.html
escape: '{{style_content_end}}'
escape_captures:
1: source.css.embedded.html
2: comment.block.html punctuation.definition.comment.end.html
3: source.css.embedded.html
4: comment.block.html punctuation.definition.comment.end.html

tag-event-attribute-value:
- match: \"
scope:
meta.string.html string.quoted.double.html
punctuation.definition.string.begin.html
embed: scope:source.js.js-template
embed_scope: meta.string.html meta.embedded.html source.js.embedded.html
escape: \"
escape_captures:
0: meta.string.html string.quoted.double.html
punctuation.definition.string.end.html
- match: \'
scope:
meta.string.html string.quoted.single.html
punctuation.definition.string.begin.html
embed: scope:source.js.js-template
embed_scope: meta.string.html meta.embedded.html source.js.embedded.html
escape: \'
escape_captures:
0: meta.string.html string.quoted.single.html
punctuation.definition.string.end.html
- include: else-pop

tag-style-attribute-value:
- match: \"
scope:
meta.string.html string.quoted.double.html
punctuation.definition.string.begin.html
embed: scope:source.css.js-template#rule-list-body
embed_scope: meta.string.html meta.embedded.html source.css.embedded.html
escape: \"
escape_captures:
0: meta.string.html string.quoted.double.html
punctuation.definition.string.end.html
- match: \'
scope:
meta.string.html string.quoted.single.html
punctuation.definition.string.begin.html
embed: scope:source.css.js-template#rule-list-body
embed_scope: meta.string.html meta.embedded.html source.css.embedded.html
escape: \'
escape_captures:
0: meta.string.html string.quoted.single.html
punctuation.definition.string.end.html
- include: else-pop

tag-attribute-value-content:
- meta_prepend: true
- include: scope:source.js#string-interpolations

strings-common-content:
- meta_prepend: true
- include: scope:source.js#string-interpolations
18 changes: 18 additions & 0 deletions JavaScript/Embeddings/JSON (JS template).sublime-syntax
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
%YAML 1.2
---
# http://www.sublimetext.com/docs/syntax.html
# highlight tagged template strings
scope: source.json.js-template
version: 2
hidden: true

extends: Packages/JSON/JSON.sublime-syntax

contexts:
prototype:
- meta_prepend: true
- include: scope:source.js#text-interpolations

string-prototype:
- meta_prepend: true
- include: scope:source.js#string-interpolations
19 changes: 19 additions & 0 deletions JavaScript/Embeddings/JavaScript (JS template).sublime-syntax
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
%YAML 1.2
---
# http://www.sublimetext.com/docs/syntax.html
# highlight tagged template strings
scope: source.js.js-template
version: 2
hidden: true

extends: Packages/JavaScript/JavaScript.sublime-syntax

contexts:

prototype:
- meta_prepend: true
- include: scope:source.js#text-interpolations

string-content:
- meta_prepend: true
- include: scope:source.js#string-interpolations
4 changes: 4 additions & 0 deletions JavaScript/Indentation Rules.tmPreferences
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
(?:
# dedent closing braces
\}
# dedent closing tagged templates
| `
# detent `case ... :`
| case\b
# detent `default:`
Expand All @@ -27,6 +29,8 @@
# indent after opening braces (may be followed by whitespace or comments)
# but exclude lines such as `extern "C" {`
.* \{ (?: \s* /\*.*\*/ )* \s* (?: //.* )? $
# indent after opening tagged template: e.g.: "css`"
| .* \w+ \s* `
# indent after `case ... :`
| case\b
# indent after `default:`
Expand Down
98 changes: 82 additions & 16 deletions JavaScript/JavaScript.sublime-syntax
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,9 @@ variables:
# '@' followed by a pattern like \S but excluding literal '*' and '@'.
jsdoc_block_tag: \@[^\n\t\f\v *@]+

leading_wspace: (?:^\s*)
trailing_wspace: (?:\s*$\n?)

contexts:
main:
- meta_include_prototype: false # don't match comments before shebang
Expand Down Expand Up @@ -1011,8 +1014,7 @@ contexts:
- include: decorator-name
- include: object-property

- match: (?=`)
push: literal-string-template
- include: literal-string-templates

- match: (?={{function_call_after_lookahead}})
push: function-call-arguments
Expand Down Expand Up @@ -1078,8 +1080,7 @@ contexts:
left-expression-end:
- include: expression-break

- match: (?=`)
push: literal-string-template
- include: literal-string-templates

- match: '{{function_call_after_lookahead}}'
push: function-call-arguments
Expand Down Expand Up @@ -1223,16 +1224,76 @@ contexts:
pop: 1
- include: string-content

literal-string-templates:
- match: (?=(?:{{identifier_name}}\s*)?`)
push: literal-string-template

literal-string-template:
- match: \`
scope: punctuation.definition.string.begin.js
# Notes:
# Consume trailing whitespace after opening punctuation
# and leading whitespace in front of closing punctuation
# to maintain JavaScript indentation rules until embedded
# code really begins/ends. It's required for embedded code
# to be indented using global JavaScript indentation rules.
- match: (css)\s*((\`){{trailing_wspace}}?)
captures:
1: variable.function.tagged-template.js
2: meta.string.js string.quoted.other.js
3: punctuation.definition.string.begin.js
embed: scope:source.css.js-template
embed_scope: meta.string.js source.css.embedded.js
escape: '{{leading_wspace}}?(\`)'
escape_captures:
0: meta.string.js string.quoted.other.js
1: punctuation.definition.string.end.js
pop: 1
- match: (html)\s*((\`){{trailing_wspace}}?)
captures:
1: variable.function.tagged-template.js
2: meta.string.js string.quoted.other.js
3: punctuation.definition.string.begin.js
embed: scope:text.html.js-template
embed_scope: meta.string.js text.html.embedded.js
escape: '{{leading_wspace}}?(\`)'
escape_captures:
0: meta.string.js string.quoted.other.js
1: punctuation.definition.string.end.js
pop: 1
- match: (js)\s*((\`){{trailing_wspace}}?)
captures:
1: variable.function.tagged-template.js
2: meta.string.js string.quoted.other.js
3: punctuation.definition.string.begin.js
embed: scope:source.js.js-template
embed_scope: meta.string.js source.js.embedded.js
escape: '{{leading_wspace}}?(\`)'
escape_captures:
0: meta.string.js string.quoted.other.js
1: punctuation.definition.string.end.js
pop: 1
- match: (json)\s*((\`){{trailing_wspace}}?)
captures:
1: variable.function.tagged-template.js
2: meta.string.js string.quoted.other.js
3: punctuation.definition.string.begin.js
embed: scope:source.json.js-template
embed_scope: meta.string.js source.json.embedded.js
escape: '{{leading_wspace}}?(\`)'
escape_captures:
0: meta.string.js string.quoted.other.js
1: punctuation.definition.string.end.js
pop: 1
- match: (?:({{identifier_name}})\s*)?(\`)
captures:
1: variable.function.tagged-template.js
2: meta.string.js string.quoted.other.js punctuation.definition.string.begin.js
set: literal-string-template-content

literal-string-template-content:
- meta_include_prototype: false
- meta_scope: meta.string.js string.quoted.other.js
- meta_content_scope: meta.string.js string.quoted.other.js
- match: \`
scope: punctuation.definition.string.end.js
scope: meta.string.js string.quoted.other.js punctuation.definition.string.end.js
pop: 1
- include: string-interpolations
- include: string-content
Expand All @@ -1250,13 +1311,22 @@ contexts:

string-interpolation-content:
- clear_scopes: 1
- meta_scope: meta.interpolation.js
- meta_content_scope: source.js.embedded
- include: text-interpolation-content

text-interpolations:
- match: \$\{
scope: punctuation.section.interpolation.begin.js
push: text-interpolation-content

text-interpolation-content:
- meta_scope: meta.interpolation.js
- meta_content_scope: source.js.embedded
- match: \}
scope: punctuation.section.interpolation.end.js
pop: 1
- match: (?=\S)
push: expression
- include: expressions

regexp-complete:
- match: '/'
Expand Down Expand Up @@ -2088,9 +2158,7 @@ contexts:
- function-name-meta
- literal-variable-base

- match: '{{identifier_name}}(?={{nothing}}`)'
scope: variable.function.tagged-template.js
pop: 1
- include: literal-string-template

- match: '{{constant_identifier}}(?=\s*(?:{{dot_accessor}}|\[))'
scope: support.class.js
Expand Down Expand Up @@ -2523,9 +2591,7 @@ contexts:
- match: '(?=#?{{identifier_name}}{{function_call_after_lookahead}})'
set: call-method-name

- match: '{{identifier_name}}(?={{nothing}}`)'
scope: variable.function.tagged-template.js
pop: 1
- include: literal-string-template

- include: object-property-base
- include: else-pop
Expand Down
5 changes: 1 addition & 4 deletions JavaScript/tests/syntax_test_js.js
Original file line number Diff line number Diff line change
Expand Up @@ -273,9 +273,6 @@ tag `template`;
// <- variable.function.tagged-template
// ^^^^^^^^^^ meta.string string.quoted.other

tag/**/`template`;
// <- variable.function.tagged-template

x ? y // y is a template tag!
`template` : z;
// ^ keyword.operator.ternary
Expand Down Expand Up @@ -1051,7 +1048,7 @@ foo
// ^^^ variable.function.tagged-template
// ^^ meta.string string.quoted.other punctuation.definition.string

foo.tag/**/``;
foo.tag ``;
// ^^^ variable.function.tagged-template

return new Promise(resolve => preferenceObject.set({value}, resolve));
Expand Down
Loading