Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Disable tests against ST4169 #4018

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

deathaxe
Copy link
Collaborator

This change is required for #4015 to succeed.

We can re-enable stable tests, once the next stable release is made.

This change is required for sublimehq#4015 to succeed.

We can re-enable stable tests, once the next stable release is made.
@keith-hall
Copy link
Collaborator

Do we know why it doesn't work as expected on current the stable build?

@deathaxe
Copy link
Collaborator Author

deathaxe commented Jul 28, 2024

Yes, because indentation rule selectors make use of sublimehq/sublime_text#2152 to recursively select the correct ruleset in deeply nested alternating json objects/lists and function constructs.

var foo = {             
  case: () => {          // data: don't dedent
    switch () {
    case:                // code: dedent
      var bar = {
        case: () => {    // data: don't dedent
          ...
        }
      }        
   }
}

This is available as of ST4173.

In all builds before, selectors match the outermost contexts only and thus indentation starts to fail in on of the inner object/function blocks.

Changelog

- ...
- Improved accuracy of scope selectors
- ...

Copy link
Collaborator

@FichteFoll FichteFoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might also be able to use continue-on-error: true to make the action not fail checks, but it's not exactly allowing the failure.

See also actions/runner#2347.

I think in general it's not that problematic if syntax tests break on a stable build because we are, after all, targeting the next ST build which is going to be closer to the last dev build regardless.

@deathaxe deathaxe merged commit ac567af into sublimehq:master Jul 28, 2024
1 check passed
@deathaxe deathaxe deleted the ci-disable-stable-tests branch July 28, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants