[PHP] Adjust snippet selectors #3631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds `text.html.php` to those snippets which are currently triggered by `embedding.php - source.php` only. The goal is to enable those snippets in inherit syntax such as Laravel Blade, which don't use `embedding.php` but will probably be scoped `text.html.php.blade`. Note: Basically `embedding.php` is maintained only in order to enable those snippets in an empty document, as `text.html.php` is added to stack not before the first character is typed.
jfcherng
approved these changes
Dec 20, 2022
michaelblyons
approved these changes
Dec 22, 2022
|
I've decided to stay with Will need to think about relevance of this PR and possible other implications about snippet selectors in templates, I've learned about during the last few days. It means, there may be further tweaks needed to avoid snippets from being triggered within embedded template code or directive's etc. |
deathaxe
added
the
on hold
deathaxe
removed
the
on hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
text.html.phpto those snippets which are currently triggered byembedding.php - source.phponly.The goal is to enable those snippets in inherit syntax such as Laravel Blade, which don't use
embedding.phpbut will probably be scopedtext.html.php.blade.