Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Markdown] Not all code-blocks are syntax-highlighted #3157

Closed
Alexey-T opened this issue Dec 6, 2021 · 3 comments · Fixed by #3167
Closed

[Markdown] Not all code-blocks are syntax-highlighted #3157

Alexey-T opened this issue Dec 6, 2021 · 3 comments · Fixed by #3167
Labels
T: bug A bug in an existing language feature

Comments

@Alexey-T
Copy link

Alexey-T commented Dec 6, 2021

What happened?

In this file not all blocks are handled.
fenced-nice.md

Blocks for CSS and Cmd (Batch) are bad

Screenshot from 2021-12-06 15-36-56
@Alexey-T Alexey-T added the T: bug A bug in an existing language feature label Dec 6, 2021
@Alexey-T
Copy link
Author

Alexey-T commented Dec 6, 2021

'cmd' alias is from here!
https://github.com/highlightjs/highlight.js/blob/main/SUPPORTED_LANGUAGES.md

deathaxe added a commit to deathaxe/sublime-packages that referenced this issue Dec 11, 2021
@deathaxe
[Markdown] Sync with MarkdownEditing 3.1.0
ebf80a8 
Fixes sublimehq#1930
Fixes sublimehq#2542
Fixes sublimehq#2857
Fixes sublimehq#3073
Fixes sublimehq#3154
Fixes sublimehq#3157

This commit proposes to apply refactored Markdown syntax from
MarkdownEditing, which was originally been based on ST's default
Markdown syntax.

It is mainly a reorganization of existing contexts/patterns, which
include several fixes which have been applied during refactoring.

It does not yet introduce branching to a broader extend in order to
limit changes to the syntax test file. Those are planned for future
PRs after being developed and tested in MarkdownEditing repo.

Note:

1. All 3rd-party syntaxes or extensions have been removed.
2. For details about single changes, please follow MarkdownEditing's
   commit history. All syntax related commits start with "Syntax: ".
@deathaxe deathaxe mentioned this issue Dec 11, 2021
Merged
deathaxe added a commit to deathaxe/sublime-packages that referenced this issue Dec 11, 2021
@deathaxe
[Markdown] Sync with MarkdownEditing 3.1.0
e2f597f 
Fixes sublimehq#1930
Fixes sublimehq#2542
Fixes sublimehq#2857
Fixes sublimehq#3073
Fixes sublimehq#3154
Fixes sublimehq#3157

This commit proposes to apply refactored Markdown syntax from
MarkdownEditing, which was originally been based on ST's default
Markdown syntax.

It is mainly a reorganization of existing contexts/patterns, which
include several fixes which have been applied during refactoring.

It does not yet introduce branching to a broader extend in order to
limit changes to the syntax test file. Those are planned for future
PRs after being developed and tested in MarkdownEditing repo.

Note:

1. All 3rd-party syntaxes or extensions have been removed.
2. For details about single changes, please follow MarkdownEditing's
   commit history. All syntax related commits start with "Syntax: ".
@Alexey-T
Copy link
Author

Is this solved ?

@deathaxe
Copy link
Collaborator

deathaxe commented Dec 27, 2021 •
edited
Loading

The missing syntaxes are part of the linked PR. Solution is prepared and pending for review>merge>release.

Alternatively you could of course use MarkdownEditing, whose current release contains those fixes already.

deathaxe added a commit that referenced this issue May 7, 2022
@deathaxe
[Markdown] Refactor Syntax (#3167)
b31d078 
[Markdown] Refactor Syntax

Fixes #1930
Fixes #2542
Fixes #2857
Fixes #2942
Fixes #3073
Addresses #3154 (in ST3 compatible way)
Fixes #3157
Fixes #3170
Addresses #3228

This commit refactors Markdown syntax to 

1. improve compliance with CommonMark specification:
   https://spec.commonmark.org/0.30

   Many tests are added to proof compliance:
   https://spec.commonmark.org/0.30/spec.json

   Latest GFM syntax is based on CommonMark at the time writing,
   so those rules are included as well:
   https://github.github.com/gfm/

2. convert most anonymous to named contexts for better support
   of inheritance.

3. reorganize syntax into logical sections for better readability
   and maintainability.

4. address most Markdown related issues of sublimehq/Packages repo.
   
Main changes are:

- fix CommonMark compatibility of backslash escapes
- fix CommonMark compatibility of block quotes
- fix CommonMark compatibility of html entities
- fix CommonMark compatibility of fenced code blocks
- fix CommonMark compatibility of indented code blocks
  (mixed tabs/spaces)
- fix CommonMark compatibility of reference definitions
- fix CommonMark compatibility of thematic breaks
- update strike-through markup to use 2 tildes only
- reorganizing contexts in logical sections

Benchmarks:

This commit has no impact on parsing performance.

Notes: 

1. Some remaining CommonMark incompatibilities need further work
   using ST4's "branching" feature.
2. Main refactoring work was done in MarkdownEditing package and
   released with version 3.1.1. This commit contains the result
   of that work, except some features which rely on 3rd-party
   (syntax) packages.

   Removed features are:
   - coffee script support in front-matter
   - numerous code-block syntaxes (E.g.: Ada, Coffee Script, ...)
   - LaTex blocks
   - custom `<kbd>` tag highlighting as it doesn't meet 
     quality expectations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T: bug A bug in an existing language feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Markdown] Sync with MarkdownEditing 3.1.1 deathaxe/sublime-packages
2 participants
@Alexey-T @deathaxe