Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix driver/config restructure bug #751

Merged
merged 2 commits into from
Aug 9, 2019

Conversation

pcarruscag
Copy link
Member

Proposed Changes

@rsanfer , @talbring please keep the testcases up to date with the new options you are introducing, avoidable bugs are starting to pass...

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.

@talbring
Copy link
Member

talbring commented Aug 5, 2019

@pcarruscag I would not call that an avoidable bug considering the fact that the regression test passed.

@pcarruscag
Copy link
Member Author

It passed because the config options were not updated and so no mesh deformation was specified for any of the FSI cases.

@talbring
Copy link
Member

talbring commented Aug 5, 2019

If this has no influence on the test values then we should change these cases I would say.

@economon
Copy link
Member

economon commented Aug 6, 2019

Let’s try to keep it positive here.. @talbring has an interesting point that the tests should show some sensitivity to major changes like the grid deformation not being specified. Can they be made more sensitive to this?

@pcarruscag
Copy link
Member Author

I agree, but some do pick up those changes, just not all of them.

Anyway, you'll notice I put an assert for the condition that was causing the problem instead of an "mpi error". That is inline with the philosophy that errors/exceptions are to deal with user errors and asserts to help debugging (they are ignored with -DNDEBUG). I can off-course change it.

Copy link
Contributor

@rsanfer rsanfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just reproduced this error and indeed all static FSI cases fail, so let's merge the bugfix in.
Idea is, replacing FLUID_STRUCTURE_STATIC and FLUID_STRUCTURE with the new mesh solver, so these options should change again soon (and I'll make sure they get properly documented).
Still, I think we should add another steady-state FSI test case, to catch this kind of bugs in the regression tests. Let me do that in the coming PR.

@talbring talbring merged commit 41e624a into develop Aug 9, 2019
@pcarruscag pcarruscag deleted the fix_driver_config_restructure_bugs branch February 26, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants