Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of convective numerics classes #691

Merged
merged 49 commits into from
Jul 14, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
3483f75
base clase for central schemes
pcarruscag May 27, 2019
fa246f4
Merge branch 'develop' into refactor_convective_numerics
pcarruscag May 27, 2019
be46578
cleanup doxygen
pcarruscag May 29, 2019
8385454
fix doxygen comments
pcarruscag May 29, 2019
e5c114c
Merge branch 'feature_improve_jacobian_condition' into refactor_conve…
pcarruscag May 29, 2019
73fbbf9
Merge branch 'develop' into refactor_convective_numerics
pcarruscag May 30, 2019
c0a947c
AD hook method in central scheme base
pcarruscag May 31, 2019
e489b4d
Merge branch 'feature_improve_jacobian_condition' into refactor_conve…
pcarruscag May 31, 2019
b74abb6
Merge branch 'refactor_convective_numerics' of https://github.com/pca…
pcarruscag May 31, 2019
ee1fe12
Merge branch 'develop' into refactor_convective_numerics
vdweide Jun 9, 2019
88f1def
started base class for AUSM+up(2) and SLAU(2)
pcarruscag Jun 9, 2019
0a39f4e
Merge branch 'feature_improve_jacobian_condition' of https://github.c…
pcarruscag Jun 9, 2019
35d812f
move ausm+up2 to new framework (not working yet)
pcarruscag Jun 10, 2019
f03f144
fix ausm+up(2) after refactoring
pcarruscag Jun 11, 2019
afdaa91
move slau(2) to new framework, slau2 now derived from slau
pcarruscag Jun 11, 2019
dec8f27
started FD flux Jacobians
pcarruscag Jun 11, 2019
d1ec325
finish FD Jacobian
pcarruscag Jun 11, 2019
8cba02f
add comments, Roe Jacobian still default
pcarruscag Jun 12, 2019
0084b3f
move numerical differentiation to method, reduce burden of the framew…
pcarruscag Jun 13, 2019
01fbedd
config options for FD Jacobians and central scheme diagonal dominance…
pcarruscag Jun 13, 2019
56ec70a
preaccumulation for AUSM+up(2) and SLAU(2)
pcarruscag Jun 13, 2019
b067562
Merge branch 'feature_improve_jacobian_condition' into refactor_conve…
pcarruscag Jun 13, 2019
f107d43
update config_template
pcarruscag Jun 13, 2019
5044298
Merge branch 'develop' into refactor_convective_numerics
pcarruscag Jun 13, 2019
094967e
fix change to submodules commited by mistake
pcarruscag Jun 13, 2019
1910fce
fix change to codi
pcarruscag Jun 13, 2019
9a21f5f
Merge branch 'develop' into refactor_convective_numerics
talbring Jun 19, 2019
8e879d4
missing "start" for preaccumulation
pcarruscag Jun 21, 2019
b7e569a
preacc AUSM and CUSP, warnings about grid motion
pcarruscag Jun 21, 2019
c61e926
Merge branch 'feature_improve_jacobian_condition' into refactor_conve…
pcarruscag Jun 21, 2019
a0b7301
analytical derivatives form AUSM+up
pcarruscag Jun 24, 2019
1027170
fix errors in analytical derivatives
pcarruscag Jun 25, 2019
1dc7b8b
disabling accurate jacobians for coarse levels
pcarruscag Jun 25, 2019
c8f5206
Revert "disabling accurate jacobians for coarse levels"
pcarruscag Jun 25, 2019
aed7ae1
fix numerical precision issue in analytical derivatives
pcarruscag Jun 25, 2019
d337d8a
Merge branch 'feature_improve_jacobian_condition' into refactor_conve…
pcarruscag Jun 25, 2019
bcaa501
improve performance of AUSM+/SLAU accurate jacobian implementation
pcarruscag Jun 26, 2019
832db5e
refactor ideal gas Roe schemes to derive from common class
pcarruscag Jun 26, 2019
80adbd6
move vectors of conservatives to Roe base class
pcarruscag Jun 26, 2019
3e80db1
more warning about grid motion, clean-up member variables of AUSM+up/…
pcarruscag Jun 26, 2019
ffca2fa
Merge branch 'feature_improve_jacobian_condition' into refactor_conve…
Jun 26, 2019
1d5f4a0
Merge branch 'develop' into refactor_convective_numerics
pcarruscag Jun 26, 2019
8347331
Merge branch 'develop' into refactor_convective_numerics
pcarruscag Jun 27, 2019
9e09a82
CUSP by the book
pcarruscag Jun 27, 2019
9f0b552
Merge branch 'develop' into refactor_convective_numerics
pcarruscag Jun 27, 2019
a9e832b
updating reference residuals after investigation
pcarruscag Jul 1, 2019
3f37a0a
Merge branch 'develop' into refactor_convective_numerics
pcarruscag Jul 8, 2019
71657eb
Merge branch 'develop' into refactor_convective_numerics
pcarruscag Jul 13, 2019
ba9d18e
update testcases
pcarruscag Jul 14, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions Common/include/config_structure.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,8 @@ class CConfig {
MUSCL_Turb, /*!< \brief MUSCL scheme for the turbulence equations.*/
MUSCL_Heat, /*!< \brief MUSCL scheme for the (fvm) heat equation.*/
MUSCL_AdjFlow, /*!< \brief MUSCL scheme for the adj flow equations.*/
MUSCL_AdjTurb; /*!< \brief MUSCL scheme for the adj turbulence equations.*/
MUSCL_AdjTurb, /*!< \brief MUSCL scheme for the adj turbulence equations.*/
Use_Accurate_Jacobians; /*!< \brief Use numerically computed Jacobians for AUSM+up(2) and SLAU(2). */
bool EulerPersson; /*!< \brief Boolean to determine whether this is an Euler simulation with Persson shock capturing. */
bool FSI_Problem, /*!< \brief Boolean to determine whether the simulation is FSI or not. */
ZoneSpecific_Problem, /*!< \brief Boolean to determine whether we wish to use zone-specific solvers. */
Expand Down Expand Up @@ -584,7 +585,8 @@ class CConfig {
Kappa_2nd_Flow, /*!< \brief JST 2nd order dissipation coefficient for flow equations. */
Kappa_4th_Flow, /*!< \brief JST 4th order dissipation coefficient for flow equations. */
Kappa_2nd_Heat, /*!< \brief 2nd order dissipation coefficient for heat equation. */
Kappa_4th_Heat; /*!< \brief 4th order dissipation coefficient for heat equation. */
Kappa_4th_Heat, /*!< \brief 4th order dissipation coefficient for heat equation. */
Cent_Jac_Fix_Factor;/*!< \brief Multiply the dissipation contribution to the Jacobian of central schemes by this factor to make the global matrix more diagonal dominant. */
su2double Geo_Waterline_Location; /*!< \brief Location of the waterline. */

su2double Min_Beta_RoeTurkel, /*!< \brief Minimum value of Beta for the Roe-Turkel low Mach preconditioner. */
Expand Down Expand Up @@ -4336,6 +4338,12 @@ class CConfig {
* \return MUSCL scheme.
*/
bool GetMUSCL_AdjTurb(void);

/*!
* \brief Get whether to "Use Accurate Jacobians" for AUSM+up(2) and SLAU(2).
* \return yes/no.
*/
inline bool GetUse_Accurate_Jacobians(void) { return Use_Accurate_Jacobians; }

/*!
* \brief Get the kind of integration scheme (explicit or implicit)
Expand Down Expand Up @@ -4534,6 +4542,12 @@ class CConfig {
*/
su2double GetKappa_4th_Heat(void);

/*!
* \brief Factor by which to multiply the dissipation contribution to Jacobians of central schemes.
* \return The factor.
*/
inline su2double GetCent_Jac_Fix_Factor(void) { return Cent_Jac_Fix_Factor; }

/*!
* \brief Get the kind of integration scheme (explicit or implicit)
* for the adjoint flow equations.
Expand Down
4 changes: 4 additions & 0 deletions Common/src/config_structure.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1436,6 +1436,10 @@ void CConfig::SetConfig_Options(unsigned short val_iZone, unsigned short val_nZo
default_ad_coeff_heat[0] = 0.5; default_ad_coeff_heat[1] = 0.02;
/*!\brief JST_SENSOR_COEFF_HEAT \n DESCRIPTION: 2nd and 4th order artificial dissipation coefficients for the JST method \ingroup Config*/
addDoubleArrayOption("JST_SENSOR_COEFF_HEAT", 2, Kappa_Heat, default_ad_coeff_heat);
/*!\brief USE_ACCURATE_FLUX_JACOBIANS \n DESCRIPTION: Use numerically computed Jacobians for AUSM+up(2) and SLAU(2) \ingroup Config*/
addBoolOption("USE_ACCURATE_FLUX_JACOBIANS", Use_Accurate_Jacobians, false);
/*!\brief CENTRAL_JACOBIAN_FIX_FACTOR \n DESCRIPTION: Improve the numerical properties (diagonal dominance) of the global Jacobian matrix, 3 to 4 is "optimum" (central schemes) \ingroup Config*/
addDoubleOption("CENTRAL_JACOBIAN_FIX_FACTOR", Cent_Jac_Fix_Factor, 1.0);

/*!\brief CONV_NUM_METHOD_ADJFLOW
* \n DESCRIPTION: Convective numerical method for the adjoint solver.
Expand Down
Loading