Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding a reynolds number check #669

Merged
merged 5 commits into from
Apr 23, 2019
Merged

adding a reynolds number check #669

merged 5 commits into from
Apr 23, 2019

Conversation

WallyMaier
Copy link
Contributor

Proposed Changes

Adding a warning if a non-zero Reynolds number is used for NS or RANS simulation. Currently the code will diverge will no explanation.

  • [ x] I am submitting my contribution to the develop branch.
  • [x ] My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags).
  • [x ] My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.

oleburghardt
oleburghardt reviewed Apr 11, 2019
View reviewed changes
Copy link
Contributor

@oleburghardt oleburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, welcome and thanks for the contribution.

As a first step, adding the condition mentioned below will make all the incompressible regression tests pass. Then we go on.

Best, Ole

Common/src/config_structure.cpp Outdated Show resolved Hide resolved
@aeroamit
Copy link
Contributor

Hi Wallymaier,
I replied to your query on cfd-online regarding AP2. Did you have a look at that/things got sorted out?

@WallyMaier
Copy link
Contributor Author

Hi Amit,
I sent an email, I hope it made it to you.

economon
economon requested changes Apr 18, 2019
View reviewed changes
Copy link
Member

@economon economon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT. Just one small change for clarity.

Common/src/config_structure.cpp Outdated Show resolved Hide resolved
@aeroamit
Copy link
Contributor

Hi Wallymaier,
I got that. I will get back to you soon.

@economon
Copy link
Member

Time to merge this, thanks @WallyMaier

@economon economon merged commit 5b2bd2c into develop Apr 23, 2019
@economon economon deleted the feature_warn_fix branch April 23, 2019 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleburghardt oleburghardt oleburghardt left review comments

@economon economon economon approved these changes

Assignees
No one assigned
Labels
changelog:fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WallyMaier @aeroamit @economon @oleburghardt @talbring