-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update of CoDiPack and MeDiPack versions #660
Conversation
…aced preaccumulation
…o update_codi_medi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These seem to be two very nice changes.
For the preaccumulation part, it looks good to me in any case. It will also make these routines easier to handle for non-AD developers as there is now no explicit index treatment in the AD source files anymore.
Same for the linear solver part, it simplifies the existing code a lot. Haven't been aware of the addToTape
functionality, nice to learn about it now.
( - removed question that did not turn out to be expedient -)
AD::FuncHelper->addUserData(SolverTol); | ||
AD::FuncHelper->addUserData(MaxIter); | ||
AD::FuncHelper->addUserData(config->GetKind_DiscAdj_Linear_Solver()); | ||
AD::FuncHelper->addToTape(CSysSolve_b::Solve_b); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Proposed Changes
This PR updates codi and medi to the newest version. For externally differentiated functions and preaccumulation it now uses the interfaces provided by codi.
Related Work
This fixes #659.
PRs #650 and #653 should be merged in before (I will deal with this next week).
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.