Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the initial guess for the Newton algorithm for the parametric c… #608

Merged
merged 1 commit into from
Nov 10, 2018

Conversation

vdweide
Copy link
Contributor

@vdweide vdweide commented Nov 9, 2018

Fixed initial guess for the Newton search of the quadrilateral.

Proposed Changes

This small PR fixes the initial guess for the Newton algorithm to determine the parametric coordinates of the quadrilateral.

Related Work

N/A

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • [X ] I am submitting my contribution to the develop branch.
  • [ X] My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags).
  • [X ] My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.

Copy link
Member

@economon economon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdweide vdweide merged commit cf91b7c into develop Nov 10, 2018
@vdweide vdweide deleted the feature_fix_initial_guess_quad branch November 10, 2018 05:53
CatarinaGarbacz pushed a commit that referenced this pull request Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants