-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collection of bug fixes #598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@economon thank you for the type cast fixes in the RBF interpolation, do you compile with the Wconversion flag? I am asking because I had no warnings there and was just googling what flags might produce them.
It is likely just a compiler-specific thing. The warnings popped up using LLVM on a mac when compiling in serial in Xcode. Not sure if it's related, but it is worth checking for warnings in both pure serial and parallel, since some warnings can appear only within #ifdefs for one or the other. |
For the g++ compiler the following compiler flags are pretty good. As @economon said, do this both in sequential and parallel mode. BTW, when the regression tests go through this PR can be merged in as far as I am concerned. |
Collection of bug fixes
Proposed Changes
Give a brief overview of your contribution here in a few sentences.
Related Work
Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
Includes fix from #339, which will be closed.
Resolves #62
Resolves #54
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.