Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection of bug fixes #598

Merged
merged 7 commits into from
Oct 19, 2018
Merged

Collection of bug fixes #598

merged 7 commits into from
Oct 19, 2018

Conversation

economon
Copy link
Member

@economon economon commented Oct 15, 2018

Proposed Changes

Give a brief overview of your contribution here in a few sentences.

  • Bug fix for surface-based objectives so that they are not counted multiple times when multiple surfaces are being designed
  • Segfault fix for ParaView binary in serial.
  • Fixes so that ParaView binary works properly with SU2_SOL (writing ASCII instead) and the python scripts for gradients and shape design
  • Fixes line endings of SU2_PY/SU2/run/mergy.py
  • Fixes TecIO typecasting issue found in fixed error for 64bit platform during pointer conversion #339
  • Removes y^+ output from laminar Navier-Stokes (now RANS only)
  • Adjustment to output variables for incompressible flows
  • Removes some warnings
  • Xcode project file update

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.

Includes fix from #339, which will be closed.
Resolves #62
Resolves #54

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.

Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
@economon thank you for the type cast fixes in the RBF interpolation, do you compile with the Wconversion flag? I am asking because I had no warnings there and was just googling what flags might produce them.

@economon
Copy link
Member Author

It is likely just a compiler-specific thing. The warnings popped up using LLVM on a mac when compiling in serial in Xcode. Not sure if it's related, but it is worth checking for warnings in both pure serial and parallel, since some warnings can appear only within #ifdefs for one or the other.

@vdweide
Copy link
Contributor

vdweide commented Oct 16, 2018

For the g++ compiler the following compiler flags are pretty good.
-g -Wall -Wextra -Wno-unused-parameter -Wno-empty-body

As @economon said, do this both in sequential and parallel mode.

BTW, when the regression tests go through this PR can be merged in as far as I am concerned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants