Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Efficiency improvements for sorting + loading of grid information. #576

Merged
merged 8 commits into from
Sep 28, 2018

Conversation

economon
Copy link
Member

@economon economon commented Sep 7, 2018

Proposed Changes

Give a brief overview of your contribution here in a few sentences.

More efficient loops/maps for sorting of grid points and connectivity during initial reading/partitioning. This is important for very large meshes when running on limited resources.

Due to the changes in the initial ordering of the connectivity, this PR results in minor differences in the residuals for the regressions. They have been updated accordingly.

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.

N/A

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.

Copy link
Contributor

@vdweide vdweide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me. However, in geometry_structure.cpp there are a few places where only the whitespace has changed, see the discussion we had for the feature_hom branch. If you can change that, it is good to go.

@vdweide
Copy link
Contributor

vdweide commented Sep 27, 2018

Looks good to me now. If the regression test go through, it can be merged in.

@hlkline hlkline merged commit 7dcdfe4 into develop Sep 28, 2018
@economon economon deleted the fix_sorting branch September 28, 2018 18:46
CatarinaGarbacz pushed a commit that referenced this pull request Aug 26, 2019
Efficiency improvements for sorting + loading of grid information.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants