-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change dynamic viscosity in FD hybrid central / upwind blending to kinematic viscosity #575
Conversation
The original definition of `r_d` in DES used kinematic viscosity (not dynamic viscosity). Using dynamic viscosity is not dimensionally consistent, and will lead to problems if density is not 1. Since `GetLaminarViscosity()` and `GetEddyViscosity()` return the dynamic viscosity, it is necessary to divide by the density to get kinematic viscosity.
The behavior can be seen in the backward facing step case, as shown in a snapshot below. As currently set up,
Here's a comparison of the Here's the same case, but zoomed in at the step: With this PR, the model does indeed go to 0 near the walls and go to 1 in the highly unsteady ("LES") region after the step. |
I don't know too much about this topic, but the first thing that comes to my mind when I read this is dimensional consistency. So did somebody do a proper dimensional analysis on the implementation? Edwin |
@vdweide It's easy to do, so I'll show the dimensional analysis here. I'll use L for length, T for time, and M for mass. The original paper defined In the code you'll see:
where
So if you do the math, If you switch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and ready to merge.
Merging things in. I kept the branch, but delete it if you don't need it anymore. |
Change dynamic viscosity in FD hybrid central / upwind blending to kinematic viscosity
Proposed Changes
In both the original paper on DDES and the paper by @EduardoMolina on hybrid RANS/LES in SU2, the calculation for
r_d
uses kinematic viscosity. In SU2, the dynamic viscosity is currently used. This leads to poor behavior if density is not close to 1. This PR exchanges the dynamic viscosity for the kinematic viscosity.Related Work
This is part of the changes originally proposed in PR #552
PR Checklist